Repository navigation
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
… setup and repository management - Introduced hardcoded paths for DreamZero upstream repository and model ID. - Replaced environment variable checks with direct path management in helper functions. - Enhanced the `require_dreamzero_parity_env` function to ensure the upstream repository is correctly cloned and available. - Updated test cases to utilize the new repository management functions for better clarity and reliability. - Added local stand-in for `openpi_client` to handle missing dependencies during tests. Signed-off-by: wangyu <410167048@qq.com>
1599eaf to
540c1ad
Compare
yenuo26
changed the title
…racy helpers - Deleted obsolete test files for DreamZero accuracy, including `test_dreamzero.py` and the upstream mock server script. - Cleaned up the `helpers.py` file by removing unused functions and constants related to DreamZero. - Updated the remaining helper functions to improve clarity and maintainability. Signed-off-by: [Your Name] <your.email@example.com> Signed-off-by: wangyu <410167048@qq.com>
yenuo26
changed the title
yenuo26
changed the title
|
Dropping the upstream parity path makes sense, and the A stand-in that reuses our own pack/unpack tests our encoder against our decoder. That passes for any wire format, including a wrong one — so it stops being a contract test. #4506 is what that looks like in practice: #4282 changed the format, the tests changed with it, nothing failed, and the break surfaced only when a real |
Omni ReviewBot: no human activity for 28 days@yenuo26 this pull request has had no human commit, comment or review since 2026-08-11. Per repository policy it may be closed if it stays inactive. To keep it moving, any one of these is enough: push an update, reply to the open blocker, or post the current plan and timeline. |
Omni ReviewBot: CI is red on this head@yenuo26 required checks failed on Please fix the failure and push again; this note is updated in place when the head goes green or moves. |
4 participants
PLEASE FILL IN THE PR DESCRIPTION HERE.
Purpose
Weekly DreamZero OpenPI e2e was failing in CI (#5749):
test_dreamzero_openpi_upstream_parity) hard-failed withoutDREAMZERO_REPO/ upstream checkouttest_dreamzero_openpi_online) hard-failed without PyPIopenpi-clientRunning the upstream numerical parity path is not practical in the vLLM-Omni CI / shared test env:
pip install -e ./ its dependency tree) conflicts with the current vLLM stackopenpi-clientpinsnumpy<2, which is incompatible with the rest of the workspaceBecause that environment cannot support a reliable upstream numerical comparison, this PR deletes the accuracy parity test and the upstream mock server helpers instead of skipping or papering over missing env vars.
Coverage that remains is the online OpenPI serving contract test only:
tests/e2e/online_serving/test_dreamzero_expansion.pyopenpi_client.msgpack_numpystand-in (reusing vLLM-Omni pack/unpack) so CI does not need PyPIopenpi-clienttests/helpers/runtime.pyinto the single online test that uses themFixes #5749
Test Plan
vLLM Version: N/A (test-only)
vLLM-Omni Commit: tip of this PR
Test Result
BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.