Repository navigation
[CI] Re-enable bagel shared-memory connector test (#5475) - #5898
Merged
amy-why-3459 merged 3 commits intoAug 10, 2026
Merged
amy-why-3459 merged 3 commits into
amy-why-3459 merged 3 commits into
Conversation
… issue vllm-project#5893 Signed-off-by: wangyu <410167048@qq.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
…project#5475 Signed-off-by: wangyu <410167048@qq.com>
yenuo26
changed the title
Collaborator
Author
|
@NickCao @Gaohan123 @hsliuustc0106 please help to add merge-test label |
amy-why-3459
added
ready
1 task done
amy-why-3459
approved these changes
Aug 10, 2026
tzhouam
added a commit
that referenced
this pull request
Aug 11, 2026
The bagel shared-memory connector goldens came from main via the #5898 re-enable and deterministically mismatch this branch's output (identical actual pixels in builds 2950 and 2953 across two different torch/base images — vLLM 0.27 alignment changed the generation, not noise). CI does not upload the generated image and the assert stopped at the first bad probe, so the log never contains enough data to re-golden. Collect every probe, fail with the complete actual-value table formatted as a paste-ready reference list, and keep the tolerance unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tzhouam
added a commit
that referenced
this pull request
Aug 11, 2026
…d output Nightly builds 2953 and 2954 produced bit-identical actual pixels across two different torch/base images, so the branch's output is deterministic; the previous goldens came from main via the #5898 re-enable and only (512, 336) drifted beyond the ±10 tolerance. Update all ten probes to the values reported by 2954's full-probe failure table. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
…vllm-project#5898) Signed-off-by: wangyu <410167048@qq.com> Co-authored-by: amy-why-3459 <wuhaiyan17@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Re-enable
tests/distributed/omni_connectors/test_bagel_shared_memory_connector.py::test_bagel_img2img_shared_memory_connectorby removing the temporary@pytest.mark.skip(reason="#issue 5475").Net change vs
main: only this unskip. An earlier draft skip for #5893 on the diffusion config classification test was added and then reverted on this branch, so it is not part of the final diff.Related: #5475
Test Plan
vLLM Version: 0.26.0 (aligned with current main CI)
vLLM-Omni Commit: this PR head
pytest tests/distributed/omni_connectors/test_bagel_shared_memory_connector.py --run-level advanced_model
Test Result
Local: skip marker removed; no production code change.