Skip to content

[ROCm] [CI] Add More Tests#542

Merged
hsliuustc0106 merged 13 commits into
vllm-project:mainfrom
EmbeddedLLM:add-more-test
Jan 12, 2026
Merged

[ROCm] [CI] Add More Tests#542
hsliuustc0106 merged 13 commits into
vllm-project:mainfrom
EmbeddedLLM:add-more-test

Conversation

@tjtanaa
Copy link
Copy Markdown
Member

@tjtanaa tjtanaa commented Dec 30, 2025

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Adding four more tests. Reaching test parity as on CUDA.

Tests added:

  • Diffusion Parallelism Test
  • Diffusion GPU Worker Test
  • Omni Model Test Qwen3-Omni (supports CUDA Graph)
  • Diffusion Image Edit Test

It also addressed the ECR repository rate limit.

Test Plan

Pass the CI

Test Result

CI results https://buildkite.com/vllm/vllm-omni-amd-ci/builds/301/steps/canvas


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@tjtanaa tjtanaa marked this pull request as draft December 30, 2025 09:41
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@tjtanaa tjtanaa marked this pull request as ready for review December 30, 2025 11:14
@tjtanaa
Copy link
Copy Markdown
Member Author

tjtanaa commented Dec 30, 2025

@hsliuustc0106 it is ready for review. I have also synced with main. The Qwen3 unit tests runs with Cudagraph now.

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@tjtanaa
Copy link
Copy Markdown
Member Author

tjtanaa commented Jan 7, 2026

@hsliuustc0106 @ywang96 Ready for review.

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@hsliuustc0106
Copy link
Copy Markdown
Collaborator

shall we wait for #577

@david6666666 david6666666 added the ROCm PR related to AMD hardware label Jan 9, 2026
@tjtanaa
Copy link
Copy Markdown
Member Author

tjtanaa commented Jan 9, 2026

@hsliuustc0106 can we merge this first so that we test more cases because that PR is still work-in-progress?

Or is there a timeline when will that PR be ready?

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@hsliuustc0106 hsliuustc0106 added the ready label to trigger buildkite CI label Jan 12, 2026
@hsliuustc0106
Copy link
Copy Markdown
Collaborator

@hsliuustc0106 can we merge this first so that we test more cases because that PR is still work-in-progress?

Or is there a timeline when will that PR be ready?

OK, let's try to merge it first

@tjtanaa
Copy link
Copy Markdown
Member Author

tjtanaa commented Jan 12, 2026

@hsliuustc0106 all check passed.

@hsliuustc0106
Copy link
Copy Markdown
Collaborator

got you

Copy link
Copy Markdown
Collaborator

@hsliuustc0106 hsliuustc0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsliuustc0106 hsliuustc0106 merged commit f25cd37 into vllm-project:main Jan 12, 2026
7 checks passed
qibaoyuan pushed a commit to qibaoyuan/vllm-omni that referenced this pull request Jan 12, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: 齐保元 <qibaoyuan@xiaomi.com>
sniper35 pushed a commit to sniper35/vllm-omni that referenced this pull request Jan 12, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
qibaoyuan pushed a commit to qibaoyuan/vllm-omni that referenced this pull request Jan 12, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: 齐保元 <qibaoyuan@xiaomi.com>
with1015 pushed a commit to with1015/vllm-omni that referenced this pull request Jan 20, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@tjtanaa tjtanaa deleted the add-more-test branch January 28, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI ROCm PR related to AMD hardware

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants