Repository navigation
[bugfix] Use FlowMatchEulerDiscreteScheduler from diffusers 0.39.0 with correct RNG handling for upcoming Cosmos3 distilled models - #5176
Merged
Conversation
…t RNG handling Signed-off-by: Bartosz Stefaniak <bstefaniak@nvidia.com>
bastefaniak
requested review from
Isotr0py,
RuixiangMa,
SamitHuang,
ZJY0516,
david6666666,
princepride,
wtomin and
xuechendi
as code owners
July 17, 2026 13:41
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: Bartosz Stefaniak <bstefaniak@nvidia.com>
ywang96
approved these changes
Jul 17, 2026
ywang96
enabled auto-merge (squash)
July 17, 2026 18:36
ywang96
disabled auto-merge
July 17, 2026 18:37
1 task done
y-null
pushed a commit
to y-null/vllm-omni
that referenced
this pull request
Jul 21, 2026
…th correct RNG handling for upcoming Cosmos3 distilled models (vllm-project#5176) Signed-off-by: Bartosz Stefaniak <bstefaniak@nvidia.com> Signed-off-by: y_null <y_null@qq.com>
bowieshi
pushed a commit
to bowieshi/vllm-omni
that referenced
this pull request
Jul 22, 2026
…th correct RNG handling for upcoming Cosmos3 distilled models (vllm-project#5176) Signed-off-by: Bartosz Stefaniak <bstefaniak@nvidia.com>
nagisa-kunhah
pushed a commit
to nagisa-kunhah/vllm-omni
that referenced
this pull request
Jul 30, 2026
…th correct RNG handling for upcoming Cosmos3 distilled models (vllm-project#5176) Signed-off-by: Bartosz Stefaniak <bstefaniak@nvidia.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
…th correct RNG handling for upcoming Cosmos3 distilled models (vllm-project#5176) Signed-off-by: Bartosz Stefaniak <bstefaniak@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
vLLM-Omni depends on
diffusers==0.38.0in whichgeneratorpassed as argument toFlowMatchEulerDiscreteScheduler.step()is ignored, this results in broken generation when CP > 1 is used. This PR copiesFlowMatchEulerDiscreteSchedulerimplementation fromdiffusers==0.39.0with correct RNG handling. It's copied to separate file so no other model is impacted, this file can be deleted after migration todiffusers==0.39.0or higher.Test Plan
vLLM Version:
v0.25.0
vLLM-Omni Commit:
7aa5c9a
Test Result
Tests can be done by running generation, this one was generated by upcoming Cosmos3 model and enabled CP4:
Image generated with bugged
FlowMatchEulerDiscreteSchedulerversion:with fixed:
BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.
(anything written below this line will be removed by GitHub Actions)