Repository navigation
[Doc] Fix Qwen3-Omni modality documentation examples - #5173
Merged
hsliuustc0106 merged 3 commits intoJul 18, 2026
Merged
Conversation
Signed-off-by: psv666 <2693925048@qq.com>
psv666
requested review from
Gaohan123,
david6666666,
hsliuustc0106 and
ywang96
as code owners
July 17, 2026 10:04
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Collaborator
|
Thanks, LGTM. |
y-null
pushed a commit
to y-null/vllm-omni
that referenced
this pull request
Jul 21, 2026
Signed-off-by: psv666 <2693925048@qq.com> Co-authored-by: amy-why-3459 <wuhaiyan17@huawei.com> Signed-off-by: y_null <y_null@qq.com>
bowieshi
pushed a commit
to bowieshi/vllm-omni
that referenced
this pull request
Jul 22, 2026
Signed-off-by: psv666 <2693925048@qq.com> Co-authored-by: amy-why-3459 <wuhaiyan17@huawei.com>
nagisa-kunhah
pushed a commit
to nagisa-kunhah/vllm-omni
that referenced
this pull request
Jul 30, 2026
Signed-off-by: psv666 <2693925048@qq.com> Co-authored-by: amy-why-3459 <wuhaiyan17@huawei.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
Signed-off-by: psv666 <2693925048@qq.com> Co-authored-by: amy-why-3459 <wuhaiyan17@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect modality descriptions and examples in the Qwen3-Omni online serving documentation.
Purpose
The Qwen3-Omni online serving docs contained several inaccuracies in the output-modality section that would mislead users into getting unexpected (or empty) responses:
Modality table mislabeled
["audio"]as "Text + Audio" —["audio"]actually produces audio-only output. "Text + Audio" requires explicitly passing["text", "audio"]. Corrected the table row.The "Text + Audio" curl/Python examples used
modalities=["audio"]— contradicting the section title. When["text", "audio"]is requested the server returns twochoices(index 0 = text, index 1 = audio), but the examples only decoded a single choice and used the wrong index. Updated the examples to pass["text", "audio"], capture the full response, and extract text fromchoices[0]and audio fromchoices[1](base64-decoded intooutput.wav).The speaker (audio-only) Python example referenced
choices[1]— audio-only responses contain a single choice, so the correct index ischoices[0].These fixes apply consistently to both
docs/user_guide/examples/online_serving/qwen3_omni.mdandexamples/online_serving/qwen3_omni/README.md.Test Plan
["text"]→ text only,["audio"]→ audio only,["text","audio"]→ text + audio.choicesindices for each modality combination.Qwen/Qwen3-Omni-30B-A3B-Instruct, run the corrected["text","audio"]curl example, confirm two choices are returned andoutput.wavplays audio.vLLM Version: 0.24.0
vLLM-Omni Commit: 7aa5c9a
Test Result
Documentation-only change; no runtime code modified. Verified by diff inspection that both copies of the example are consistent and the described
choicesindices match the server's actual response layout.