Repository navigation
Conversation
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
PTAL @yJader , @ZhengWG , @princepride |
| ) | ||
| return | ||
| if already_submitted and len(diffusion_prompt) == 1: | ||
| if len(diffusion_prompt) == 1: |
There was a problem hiding this comment.
already_submitted is only used here to distinguish the orchestrator submission path (submit_update vs submit_initial). For diffusion, both paths eventually enter the same diffusion client API and then DiffusionEngine.step/step_streaming -> add_request, so DiffusionEngine does not attach different semantics to initial vs update submissions.
Since diffusion StagePool rejects list prompts in both submit_initial and submit_update, singleton-list normalization should not depend on already_submitted. Applying it consistently makes the diffusion payload contract clearer and avoids the initial path still passing a list-shaped payload.
…llm-project#4837) Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
…llm-project#4837) Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com> Signed-off-by: Wojciech Kutak <wkutak@nvidia.com>
…llm-project#4837) Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
PLEASE FILL IN THE PR DESCRIPTION HERE.
Purpose
Fix regression imported in #4079
Resolves #4839
After some bridge func runs, diffusion_prompt is a
list[dict]. Invllm_omni/engine/orchestrator.py, Both of the two submit paths reject a list for diffusion stages, however, the unwrapdiffusion_prompt = diffusion_prompt[0]get covered only whenalready_submittedis true.This PR fixed the above regression, as well as a trivial DiffusionOutput issue in Ming Image-gen pipeline .
Test Plan
vllm serve Jonathan1909/Ming-flash-omni-2.0 --omni \ --deploy-config vllm_omni/deploy/ming_flash_omni_image.yaml \ --port 8091Send a single request with
curl -s http://127.0.0.1:8091/v1/chat/completions \ -H "Content-Type: application/json" \ -d '{ "model": "Jonathan1909/Ming-flash-omni-2.0", "messages": [{"role": "user", "content": "Please draw a cute cat."}], "modalities": ["image"] }' | jq -r '.choices[0].message.content[0].image_url.url | split(",")[1]' | base64 -d > ming_imagegen.pngvLLM Version: 0.24.0
vLLM-Omni Commit: 5c51782
Test Result
BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.
(anything written below this line will be removed by GitHub Actions)