Repository navigation
[BugFix] Add field constraints to /v1/omni/sleep and /v1/omni/wakeup - #4740
Conversation
…requests Reject empty stage_ids lists (min_length=1) and negative sleep levels (ge=0) at the entrypoint level. Unskip sleep_empty_stage_ids, sleep_negative_level, and wakeup_empty_stage_ids tests. Partial fix for vllm-project#3649. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Shaun Walsh <shaunwalsh24@gmail.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Claude: The min_length=1 constraint on stage_ids will break two existing unit tests in tests/entrypoints/openai_api/test_omni_sleep_wakeup.py:
With min_length=1, Pydantic rejects empty lists with 422 before the handler runs, so both tests fail with assert 422 == 200. These tests need to be updated to expect 422, or removed since the dfx tests in test_invalid_server_control.py now cover the same validation. |
|
Already fixed — updated both tests to expect 422 in aa309ae. |
The min_length=1 constraint on stage_ids rejects empty lists at the Pydantic layer (422) before the handler runs. Update tests to match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Shaun Walsh <shaunwalsh24@gmail.com>
aa309ae to
ae717f3
Compare
|
Hi — just pushed a fix for the failing check. This PR (along with a few related ones from our team) is a dependency for the Red Hat Midstream build of vllm-omni. Could we get a review and merge when you have a chance? Happy to address any feedback quickly. Thanks! |
Omni ReviewBot: no human activity for 48 days@Shaun-Walsh this pull request has had no human commit, comment or review since 2026-07-21. Per repository policy it may be closed if it stays inactive. To keep it moving, any one of these is enough: push an update, reply to the open blocker, or post the current plan and timeline. |
|
Hi @alex-jw-brooks & @yenuo26 just flagging this PR for review when you get a chance. |
|
@Shaun-Walsh please fix conflicts |
…lidation Signed-off-by: Shaun Walsh <shaunwalsh24@gmail.com> # Conflicts: # tests/dfx/reliability/invalid_param_test/test_invalid_server_control.py # vllm_omni/entrypoints/openai/api_server.py
|
Hey @yenuo26 conflicts resolved :) |
Omni ReviewBot: no human activity for 7 days@Shaun-Walsh this pull request has had no human commit, comment or review since 2026-09-21. Please confirm the current plan and next step. The author or a maintainer decides whether to change the PR state. To keep it moving, any one of these is enough: push an update, reply to the open blocker, or post the current plan and timeline. |
|
Hi @NickCao @yenuo26 @alex-jw-brooks @tzhouam @linyueqian looking to get this merged so I don't have as many pr's open per the new guidelines :) |
Summary
min_length=1tostage_idson bothOmniSleepRequestandOmniWakeupRequestto reject empty listsge=0toOmniSleepRequest.levelto reject negative sleep levelssleep_empty_stage_ids,sleep_negative_level, andwakeup_empty_stage_idstestsPartial fix for #3649.
Test plan