Repository navigation
[Bugfix] Add back resolving from deploy config written pipeline in StageConfigFactory - #4729
Merged
alex-jw-brooks merged 3 commits intoJun 26, 2026
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
yuanheng-zhao
force-pushed
the
fix/pipeline-model-cls-res
branch
from
June 25, 2026 16:59
f881585 to
5da2701
Compare
Collaborator
Author
|
PTAL @alex-jw-brooks |
alex-jw-brooks
self-requested a review
June 25, 2026 19:10
alex-jw-brooks
approved these changes
Jun 25, 2026
alex-jw-brooks
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! Can you please add a regression test to tests/test_config_factory.py to cover this case? E.g.,
def test_resolve_when_autodetect_resolves_none(self):
"""Regression test for: https://github.com/vllm-project/vllm-omni/issues/4726"""
deploy_path = get_deploy_config_path("ming_tts.yaml")
resolved_config = StageConfigFactory.create_from_model(
model="inclusionAI/Ming-omni-tts-0.5B",
deploy_config_path=deploy_path,
)
assert resolved_config is not None
assert len(resolved_config) > 0Already checked to make sure it fails on main and passes on your branch
hsliuustc0106
left a comment
Collaborator
There was a problem hiding this comment.
Bugfix looks correct.
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
1 task done
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
…ageConfigFactory (vllm-project#4729) Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE.
Purpose
Resolves #4726
I didn't refactor or move the orders of the previous paths in
StageConfigFactory.create_from_model, as we don't want to import significant changes which require a lot of testing. Instead, I added the user written deploy-config pipeline path (pipeline key in deploy yaml) at the end ofStageConfigFactory.create_from_model, so that models fail for the other resolutions (e.g., model type none or generic, etc) will get into this path as an additional try.Test Plan
Serve
inclusionAI/Ming-omni-tts-0.5Bvllm-omni serve inclusionAI/Ming-omni-tts-0.5B \ --deploy-config vllm_omni/deploy/ming_tts.yaml \ --omni \ --port 8091 \ --enforce-eager vllm-omni serve inclusionAI/Ming-omni-tts-0.5B \ --omni \ --port 8091 \ --enforce-eagerServe
inclusionAI/Ming-omni-tts-16.8B-A3BvLLM Version: 0.23
vLLM-Omni Commit: on top of f881585
Test Result
I run serve and simple request on all the above four commands (Ming-omni-tts-0.5B and Ming-omni-tts-16.8B-A3B; with and without deploy-config arg). Servers get launched and configs get resolved correctly.
BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.
(anything written below this line will be removed by GitHub Actions)