Skip to content

[Bugfix] Add back resolving from deploy config written pipeline in StageConfigFactory - #4729

Merged
alex-jw-brooks merged 3 commits into
vllm-project:mainfrom
yuanheng-zhao:fix/pipeline-model-cls-res
Jun 26, 2026
Merged

alex-jw-brooks merged 3 commits into
vllm-project:mainfrom
yuanheng-zhao:fix/pipeline-model-cls-res

Conversation

@yuanheng-zhao

@yuanheng-zhao yuanheng-zhao commented Jun 25, 2026 •

Copy link
Copy Markdown
Collaborator

PLEASE FILL IN THE PR DESCRIPTION HERE.

Purpose

Resolves #4726

I didn't refactor or move the orders of the previous paths in StageConfigFactory.create_from_model, as we don't want to import significant changes which require a lot of testing. Instead, I added the user written deploy-config pipeline path (pipeline key in deploy yaml) at the end of StageConfigFactory.create_from_model, so that models fail for the other resolutions (e.g., model type none or generic, etc) will get into this path as an additional try.

Test Plan

Serve inclusionAI/Ming-omni-tts-0.5B

vllm-omni serve inclusionAI/Ming-omni-tts-0.5B \
    --deploy-config vllm_omni/deploy/ming_tts.yaml \
    --omni \
    --port 8091 \
    --enforce-eager

vllm-omni serve inclusionAI/Ming-omni-tts-0.5B \
    --omni \
    --port 8091 \
    --enforce-eager

Serve inclusionAI/Ming-omni-tts-16.8B-A3B

vllm-omni serve inclusionAI/Ming-omni-tts-16.8B-A3B --deploy-config vllm_omni/deploy/ming_tts_moe.yaml --omni --port 8091

vllm-omni serve inclusionAI/Ming-omni-tts-16.8B-A3B --omni --port 8091

vLLM Version: 0.23

vLLM-Omni Commit: on top of f881585

Test Result

I run serve and simple request on all the above four commands (Ming-omni-tts-0.5B and Ming-omni-tts-16.8B-A3B; with and without deploy-config arg). Servers get launched and configs get resolved correctly.

BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.
(anything written below this line will be removed by GitHub Actions)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@yuanheng-zhao yuanheng-zhao changed the title Fix/pipeline model cls res [Bugfix] Add back resolving from deploy config written pipeline in StageConfigFactory Jun 25, 2026
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
@yuanheng-zhao
yuanheng-zhao force-pushed the fix/pipeline-model-cls-res branch from f881585 to 5da2701 Compare June 25, 2026 16:59
@yuanheng-zhao

Copy link
Copy Markdown
Collaborator Author

PTAL @alex-jw-brooks

@alex-jw-brooks
alex-jw-brooks self-requested a review June 25, 2026 19:10

@alex-jw-brooks alex-jw-brooks left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you please add a regression test to tests/test_config_factory.py to cover this case? E.g.,

    def test_resolve_when_autodetect_resolves_none(self):
        """Regression test for: https://github.com/vllm-project/vllm-omni/issues/4726"""
        deploy_path = get_deploy_config_path("ming_tts.yaml")
        resolved_config = StageConfigFactory.create_from_model(
            model="inclusionAI/Ming-omni-tts-0.5B",
            deploy_config_path=deploy_path,
        )
        assert resolved_config is not None
        assert len(resolved_config) > 0

Already checked to make sure it fails on main and passes on your branch

@hsliuustc0106 hsliuustc0106 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix looks correct.

Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
@yuanheng-zhao
yuanheng-zhao requested a review from yenuo26 as a code owner June 26, 2026 01:40
@yuanheng-zhao yuanheng-zhao added the ready label to trigger buildkite CI label Jun 26, 2026
@yuanheng-zhao yuanheng-zhao added this to the v0.24.0 milestone Jun 26, 2026
@alex-jw-brooks
alex-jw-brooks merged commit 580a0ef into vllm-project:main Jun 26, 2026
8 of 9 checks passed
@yuanheng-zhao
yuanheng-zhao deleted the fix/pipeline-model-cls-res branch June 26, 2026 06:57
khairulkabir1661 pushed a commit to khairulkabir1661/vllm-omni that referenced this pull request Sep 25, 2026
…ageConfigFactory (vllm-project#4729)

Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Model class not found in diffusion model registry

3 participants