Skip to content

[refactor] Flatten Ming-flash-omni-2.0 imagegen args - #4587

Merged
hsliuustc0106 merged 4 commits into
vllm-project:mainfrom
yuanheng-zhao:refactor/ming-imagegen-flatten-args
Jun 24, 2026
Merged

hsliuustc0106 merged 4 commits into
vllm-project:mainfrom
yuanheng-zhao:refactor/ming-imagegen-flatten-args

Conversation

@yuanheng-zhao

@yuanheng-zhao yuanheng-zhao commented Jun 21, 2026 •

Copy link
Copy Markdown
Collaborator

PLEASE FILL IN THE PR DESCRIPTION HERE.

Purpose

  1. Clean up the nested args resolution in Ming-flash-omni-2.0 image-gen pipeline.
  2. Prerequisite for [RFC sub-task] Migrate ming_flash_omni example to standard task example + model_extras #4549

Test Plan

Launch the server

vllm serve Jonathan1909/Ming-flash-omni-2.0 --omni \
    --deploy-config vllm_omni/deploy/ming_flash_omni_image.yaml \
    --port 8091

Send requests with and without byte5_text

curl http://127.0.0.1:8091/v1/chat/completions \
  -H "Content-Type: application/json" \
  -d '{
    "model": "Jonathan1909/Ming-flash-omni-2.0",
    "modalities": ["image"],
    "sampling_params_list": [
      {
        "temperature": 0.4,
        "top_p": 0.9,
        "top_k": 1,
        "max_tokens": 1,
        "seed": 42,
        "extra_args": {
          "negative_prompt": "ugly, blurry, distorted"
        }
      },
      {
        "seed": 42,
        "extra_args": {
          "steps": 6,
          "cfg": 1.5,
          "height": 512,
          "width": 512,
          "seed": 123,
          "byte5_text": ["理解与生成统一"]
        }
      }
    ],
    "messages": [
      {
        "role": "user",
        "content": "Draw a poster."
      }
    ]
  }' \
  | jq -r '.choices[0].message.content[0].image_url.url | split(",")[1]' \
  | base64 -d > ming_imagegen_knobs.png

vLLM Version: 0.23.0

vLLM-Omni Commit: 1292c47

Test Result

without byte5_text with byte5_text
ming_imagegen_knobs-no-byte5text ming_imagegen_knobs

BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.
(anything written below this line will be removed by GitHub Actions)

Signed-off-by: Yuanheng <jonathan.zhaoyh@gmail.com>
Signed-off-by: Yuanheng <jonathan.zhaoyh@gmail.com>

@hsliuustc0106 hsliuustc0106 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 blocking issues above

Comment thread examples/online_serving/ming_flash_omni/README.md
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@yuanheng-zhao

Copy link
Copy Markdown
Collaborator Author

PTAL @ZhengWG , @princepride

@princepride princepride self-assigned this Jun 22, 2026
Comment on lines 339 to 341
if isinstance(texts, list) and texts:
return [t for t in texts if isinstance(t, str)]
return None

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vllm_omni/diffusion/models/ming_flash_omni/pipeline_ming_imagegen.py#L239-L241

Seems byte5_text can be string, but you did't consider this type, right?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Revised as allowing str as well

@princepride princepride left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left some comments.

Signed-off-by: Yuanheng <jonathan.zhaoyh@gmail.com>
@ZhengWG

ZhengWG commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

LGTM, this makes the byte5_text flow cleaner, Thx!

@yuanheng-zhao yuanheng-zhao added the ready label to trigger buildkite CI label Jun 23, 2026
@princepride
princepride enabled auto-merge (squash) June 24, 2026 08:59
@hsliuustc0106
hsliuustc0106 disabled auto-merge June 24, 2026 09:01
@hsliuustc0106
hsliuustc0106 merged commit fb3abb3 into vllm-project:main Jun 24, 2026
5 of 6 checks passed
@yuanheng-zhao
yuanheng-zhao deleted the refactor/ming-imagegen-flatten-args branch June 24, 2026 09:13
khairulkabir1661 pushed a commit to khairulkabir1661/vllm-omni that referenced this pull request Sep 25, 2026
Signed-off-by: Yuanheng <jonathan.zhaoyh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants