Repository navigation
[refactor] Flatten Ming-flash-omni-2.0 imagegen args - #4587
Merged
hsliuustc0106 merged 4 commits intoJun 24, 2026
Merged
hsliuustc0106 merged 4 commits into
hsliuustc0106 merged 4 commits into
Conversation
Signed-off-by: Yuanheng <jonathan.zhaoyh@gmail.com>
Signed-off-by: Yuanheng <jonathan.zhaoyh@gmail.com>
hsliuustc0106
previously requested changes
Jun 21, 2026
hsliuustc0106
left a comment
Collaborator
There was a problem hiding this comment.
2 blocking issues above
yuanheng-zhao
marked this pull request as ready for review
June 22, 2026 02:42
yuanheng-zhao
requested review from
Gaohan123,
Isotr0py,
RuixiangMa,
SamitHuang,
ZJY0516,
david6666666,
gcanlin,
princepride,
tzhouam,
wtomin and
ywang96
as code owners
June 22, 2026 02:42
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Collaborator
Author
|
PTAL @ZhengWG , @princepride |
princepride
reviewed
Jun 22, 2026
Comment on lines
339
to
341
| if isinstance(texts, list) and texts: | ||
| return [t for t in texts if isinstance(t, str)] | ||
| return None |
Collaborator
There was a problem hiding this comment.
vllm_omni/diffusion/models/ming_flash_omni/pipeline_ming_imagegen.py#L239-L241
Seems byte5_text can be string, but you did't consider this type, right?
Collaborator
Author
There was a problem hiding this comment.
Good catch. Revised as allowing str as well
princepride
approved these changes
Jun 22, 2026
princepride
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just left some comments.
Signed-off-by: Yuanheng <jonathan.zhaoyh@gmail.com>
Contributor
|
LGTM, this makes the byte5_text flow cleaner, Thx! |
princepride
approved these changes
Jun 24, 2026
princepride
enabled auto-merge (squash)
June 24, 2026 08:59
hsliuustc0106
disabled auto-merge
June 24, 2026 09:01
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
Signed-off-by: Yuanheng <jonathan.zhaoyh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE.
Purpose
Test Plan
Launch the server
vllm serve Jonathan1909/Ming-flash-omni-2.0 --omni \ --deploy-config vllm_omni/deploy/ming_flash_omni_image.yaml \ --port 8091Send requests with and without
byte5_textvLLM Version: 0.23.0
vLLM-Omni Commit: 1292c47
Test Result
BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.
(anything written below this line will be removed by GitHub Actions)