Repository navigation
[Bugfix] Fix missing memory metrics info for bagel (ar->dit diffusion) - #4477
Merged
hsliuustc0106 merged 3 commits intoJun 17, 2026
Merged
hsliuustc0106 merged 3 commits into
hsliuustc0106 merged 3 commits into
Conversation
Signed-off-by: natureofnature <wzliu@connect.hku.hk>
natureofnature
requested review from
Isotr0py,
RuixiangMa,
SamitHuang,
ZJY0516,
princepride,
wtomin and
yenuo26
as code owners
June 16, 2026 07:29
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
natureofnature
changed the title
Signed-off-by: natureofnature <wzliu@connect.hku.hk>
hsliuustc0106
left a comment
hsliuustc0106
left a comment
Collaborator
There was a problem hiding this comment.
Return stage metrics fix looks correct.
hsliuustc0106
approved these changes
Jun 17, 2026
Nughm3
pushed a commit
to Nughm3/vllm-omni
that referenced
this pull request
Jun 18, 2026
vllm-project#4477) Signed-off-by: natureofnature <wzliu@connect.hku.hk> Co-authored-by: Alicia <115451386+congw729@users.noreply.github.com>
alex-jw-brooks
pushed a commit
to alex-jw-brooks/vllm-omni
that referenced
this pull request
Jun 23, 2026
vllm-project#4477) Signed-off-by: natureofnature <wzliu@connect.hku.hk> Co-authored-by: Alicia <115451386+congw729@users.noreply.github.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
vllm-project#4477) Signed-off-by: natureofnature <wzliu@connect.hku.hk> Co-authored-by: Alicia <115451386+congw729@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE.
Purpose
Refer to #4289, since June 4th, memory metric info is lost in Bagel perf test. This PR restores BAGEL profiler memory metrics by automatically passing return_stage_metrics=true for profiler-enabled diffusion benchmarks, so dashboard artifacts contain peak_memory_mb_* again.
Test Plan
python3 -m pytest tests/dfx/perf/scripts/run_diffusion_benchmark.py \ --test-config-file tests/dfx/perf/tests/test_bagel_vllm_omni.json \ -q -s --tb=shortvLLM Version: 0.22
vLLM-Omni Commit: c58a02c
Test Result
4 passed, 16 warnings in 711.21s，exit code 0
BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.
(anything written below this line will be removed by GitHub Actions)