Repository navigation
Remove unregister_vllm_metrics no-op patch - #4396
Merged
hsliuustc0106 merged 5 commits intoJun 18, 2026
Merged
Conversation
Signed-off-by: vraiti <vraiti@redhat.com>
vraiti
requested review from
Gaohan123,
hsliuustc0106 and
ywang96
as code owners
June 12, 2026 17:58
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: vraiti <vraiti@redhat.com>
Collaborator
Contributor
Author
The referenced CI failures seem preexisting? My code doesn't touch anything to do with Diffusers SP |
Collaborator
|
CI triage for Buildkite build #11472: this looks introduced by this PR. Evidence:
Likely fix: either update the Prometheus tests and verify the new |
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: vraiti <vraiti@redhat.com>
Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com>
Nughm3
pushed a commit
to Nughm3/vllm-omni
that referenced
this pull request
Jun 18, 2026
Signed-off-by: vraiti <vraiti@redhat.com> Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
alex-jw-brooks
pushed a commit
to alex-jw-brooks/vllm-omni
that referenced
this pull request
Jun 23, 2026
Signed-off-by: vraiti <vraiti@redhat.com> Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This was referenced Jul 21, 2026
pdtgct
pushed a commit
to pdtgct/vllm-omni
that referenced
this pull request
Jul 29, 2026
…ing sections Reverts b9fe67b's edits to inherited documentation content (lead direction: the metrics change should only ADD our own documentation, not rewrite pages this fork inherits -- prefix rewrites, gating-claim rewrites, and sentence deletions all restored byte-exact). The usage page's Streaming Session Metrics section and the design page's Path 5 remain, now purely additive: both files diff against the pre-docs state with zero deletions. Research recorded for the prefix question (verified against upstream vllm-project/vllm-omni and the live exposition): vllm:omni_ was the ORIGINAL family prefix (upstream vllm-project#3576, 2026-06-01) and was renamed to vllm_omni: upstream (vllm-project#4396, 2026-06-17, which also removed the unregister_vllm_metrics patch) with a regression test pinning the legacy names as dropped (tests/metrics/test_transfer.py::test_legacy_ms_family_names_dropped on upstream main). Our pin base (2026-07-06) postdates the rename; a live scrape shows 65 upstream vllm: engine families plus 37 vllm_omni: omni families and zero vllm:omni_. Upstream's own docs still say vllm:omni_ -- they lag their code; that drift is upstream's to fix, not this fork's. The streaming families build every name from definitions.METRIC_PREFIX, the same constant every sibling omni family uses, so they conform to the existing convention by construction; the added sections state this explicitly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016vBNWkPjg5HgJoK2rKfuYY Signed-off-by: Pete Tanski <YOUR_ID+pdtgct@users.noreply.github.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
Signed-off-by: vraiti <vraiti@redhat.com> Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE.
Purpose
Previously, vLLM
unregister_vllm_metricswould cause VLLMPrometheusMetrics to destroyvllm_omni:-namespaced metrics upon construction. This has been fixed withhttps://github.com/vllm-project/vllm/pull/42331, so the monkey-patch and subsequent warningTest Plan
vLLM Version:
v0.22.0
vLLM-Omni Commit:
54a9d24
Test Result
Current /metrics:
metrics-before.txt
/metrics after patch:
metrics-after.txt
Server boot logs:
vllm-omni-logs-after.txt
BEFORE SUBMITTING: read CONTRIBUTING.md and run the precheck-pr skill with the code agent for a self-check against project conventions.
(anything written below this line will be removed by GitHub Actions)