Skip to content

[BugFix]Fix diffusion profile RPC None results - #4372

Merged
lishunyang12 merged 3 commits into
vllm-project:mainfrom
yixiaoer:bug-dev/issue-4288
Jun 21, 2026
Merged

lishunyang12 merged 3 commits into
vllm-project:mainfrom
yixiaoer:bug-dev/issue-4288

Conversation

@yixiaoer

Copy link
Copy Markdown
Contributor

Fixes #4288

Purpose

The diffusion client currently uses None to mean "RPC result not available yet". Profiling RPCs can also legitimately return None, so successful responses are misread as missing and the request keeps waiting forever. This PR switches the missing-result check to a dedicated sentinel value so /start_profile and /stop_profile can return normally.

Test Plan

  • Manual end-to-end validation on a single-node 8 x H100
  • Reproduced on tencent/HunyuanImage-3.0-Instruct with a tuned 4+4 multi-stage config:
    • max_num_seqs: 1
    • max_num_batched_tokens: 6144
    • max_tokens: 128
  • Compared:
    • an unfixed-minimal control tree where only this sentinel fix was reverted
    • the fixed tree with this patch applied
  • Verified both API behavior and profiler output generation on the fixed tree

vLLM Version: 0.22.0

vLLM-Omni Commit: d6ad418

Test Result

  • Before this change:

    • the Hunyuan service reached /health = 200
    • POST /start_profile timed out after about 60s with HTTP_CODE=000
    • POST /stop_profile also timed out after about 60s
    • server logs showed the profiler path was entered, but the request never completed
  • After this change:

    • the Hunyuan service reached /health = 200
    • POST /start_profile returned 200
    • POST /stop_profile returned 200
    • server logs showed Profiler started., Profiler stopped., and 200 OK for both endpoints
    • profiler traces were exported successfully for both stage-0 AR and stage-1 diffusion ranks

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@RuixiangMa RuixiangMa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yixiaoer Thans for your contribution, can you also add a ut to cover this?

@hsliuustc0106

Copy link
Copy Markdown
Collaborator

Reviewed PR #4372: [BugFix]Fix diffusion profile RPC None results

@yixiaoer
yixiaoer requested a review from yenuo26 as a code owner June 12, 2026 15:53
@yixiaoer
yixiaoer force-pushed the bug-dev/issue-4288 branch 2 times, most recently from e3b845e to 327544f Compare June 12, 2026 16:05
@yixiaoer
yixiaoer requested a review from RuixiangMa June 12, 2026 16:16
@Bounty-hunter

Bounty-hunter commented Jun 14, 2026 •

Copy link
Copy Markdown
Collaborator

I tested it and it works, but it returns [[null, null], null], which is quite confusing. Could you fix the response format as well?

@Gaohan123 Gaohan123 added this to the v0.24.0 milestone Jun 18, 2026
@yixiaoer
yixiaoer requested a review from tzhouam as a code owner June 21, 2026 07:05
@lishunyang12

Copy link
Copy Markdown
Collaborator

Please fix DCO.

yixiaoer added 3 commits June 21, 2026 15:30
Signed-off-by: yixiaoer <shin@yixiaoer.sg>
Signed-off-by: yixiaoer <shin@yixiaoer.sg>
Signed-off-by: yixiaoer <shin@yixiaoer.sg>
@yixiaoer
yixiaoer force-pushed the bug-dev/issue-4288 branch from 230a712 to 40d9722 Compare June 21, 2026 07:30
@yixiaoer

yixiaoer commented Jun 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Fixed the response format @Bounty-hunter , and also fixed DCO @lishunyang12, thank you.

@lishunyang12 lishunyang12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lishunyang12 lishunyang12 added the ready label to trigger buildkite CI label Jun 21, 2026
@lishunyang12
lishunyang12 merged commit 1292c47 into vllm-project:main Jun 21, 2026
8 checks passed
@yixiaoer
yixiaoer deleted the bug-dev/issue-4288 branch June 21, 2026 09:17
khairulkabir1661 pushed a commit to khairulkabir1661/vllm-omni that referenced this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The /start_profile and /stop_profile api are hanging.

6 participants