Repository navigation
[BugFix]Fix diffusion profile RPC None results - #4372
Merged
Merged
Conversation
yixiaoer
requested review from
Isotr0py,
RuixiangMa,
SamitHuang,
ZJY0516,
david6666666,
princepride and
wtomin
as code owners
June 12, 2026 06:19
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
1 task done
RuixiangMa
reviewed
Jun 12, 2026
RuixiangMa
left a comment
Collaborator
There was a problem hiding this comment.
@yixiaoer Thans for your contribution, can you also add a ut to cover this?
Collaborator
|
Reviewed PR #4372: [BugFix]Fix diffusion profile RPC None results |
yixiaoer
force-pushed
the
bug-dev/issue-4288
branch
2 times, most recently
from
June 12, 2026 16:05
e3b845e to
327544f
Compare
Collaborator
|
I tested it and it works, but it returns |
Collaborator
|
Please fix DCO. |
Signed-off-by: yixiaoer <shin@yixiaoer.sg>
Signed-off-by: yixiaoer <shin@yixiaoer.sg>
Signed-off-by: yixiaoer <shin@yixiaoer.sg>
yixiaoer
force-pushed
the
bug-dev/issue-4288
branch
from
June 21, 2026 07:30
230a712 to
40d9722
Compare
Contributor
Author
|
Fixed the response format @Bounty-hunter , and also fixed DCO @lishunyang12, thank you. |
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
Signed-off-by: yixiaoer <shin@yixiaoer.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4288
Purpose
The diffusion client currently uses
Noneto mean "RPC result not available yet". Profiling RPCs can also legitimately returnNone, so successful responses are misread as missing and the request keeps waiting forever. This PR switches the missing-result check to a dedicated sentinel value so/start_profileand/stop_profilecan return normally.Test Plan
8 x H100tencent/HunyuanImage-3.0-Instructwith a tuned4+4multi-stage config:max_num_seqs: 1max_num_batched_tokens: 6144max_tokens: 128unfixed-minimalcontrol tree where only this sentinel fix was revertedvLLM Version: 0.22.0
vLLM-Omni Commit: d6ad418
Test Result
Before this change:
/health = 200POST /start_profiletimed out after about60swithHTTP_CODE=000POST /stop_profilealso timed out after about60sAfter this change:
/health = 200POST /start_profilereturned200POST /stop_profilereturned200Profiler started.,Profiler stopped., and200 OKfor both endpoints