Skip to content

[BugFix] Fix MammothModa2 Text-to-Image Bug - #4299

Merged
wtomin merged 5 commits into
vllm-project:mainfrom
menjiantong:fix_mammothmodal2
Jun 25, 2026
Merged

[BugFix] Fix MammothModa2 Text-to-Image Bug#4299
wtomin merged 5 commits into
vllm-project:mainfrom
menjiantong:fix_mammothmodal2

Conversation

@menjiantong

@menjiantong menjiantong commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Before submitting: run the precheck-pr skill with code agent for a self-check against project conventions — catches dead code, missing benchmarks, and title format issues.

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

fix #4298

Test Plan

1*A800 80G

python examples/offline_inference/mammothmodal2_preview/run_mammothmoda2_t2i.py \
  --model bytedance-research/MammothModa2-Preview \
  --stage-config ./vllm_omni/model_executor/stage_configs/mammoth_moda2.yaml \
  --prompt "A stylish woman riding a motorcycle in NYC, movie poster style" \
  --height 1024 \
  --width 1024 \
  --num-inference-steps 50 \
  --text-guidance-scale 4.0 \
  --out output.png

Test Result

719b3ee11430ebe4c03167137776721a
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, please read https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md
(anything written below this line will be removed by GitHub Actions)

menjiantong added 3 commits June 10, 2026 00:46
menjiantong
fix Mammothmoda2Config object has no attribute llm_config
e32f507 
Signed-off-by: menjiantong <menjiantong@foxmail.com>
menjiantong
fix get_text_config
6ba4c29 
Signed-off-by: menjiantong <menjiantong@foxmail.com>
menjiantong
fix TypeError
a7e39d8 
Signed-off-by: menjiantong <menjiantong@foxmail.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

hsliuustc0106
hsliuustc0106 reviewed Jun 9, 2026
View reviewed changes
Comment thread vllm_omni/transformers_utils/configs/mammoth_moda2.py
self.tokenizer_class = "MammothUTokenizer"
self.architectures = ["Mammothmoda2Model"]

super().__init__(**kwargs)

@hsliuustc0106 hsliuustc0106 Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a regression test that verifies get_text_config() returns the correct nested text_config. This would prevent similar AttributeError issues in the future.

@menjiantong menjiantong Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I'll add a regression test.

Comment thread vllm_omni/model_executor/stage_input_processors/mammoth_moda2.py Outdated
def ar2dit(
source_outputs: list[Any],
prompts: OmniTokensPrompt | TextPrompt | None = None,
prompts: OmniTokensPrompt | TextPrompt | list | None = None,

@hsliuustc0106 hsliuustc0106 Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type annotation list | None is broad. Consider using list[OmniTokensPrompt | TextPrompt] | None for better type safety, or adding a runtime isinstance check to validate the list contents.

@menjiantong menjiantong Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this and push an update shortly.

@menjiantong
menjiantong requested a review from yenuo26 as a code owner June 10, 2026 16:05
menjiantong
fix
0e547c5 
Signed-off-by: menjiantong <menjiantong@foxmail.com>
@menjiantong

menjiantong commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@hsliuustc0106 I've addressed your comments and ut are passing. ptal, thanks.
image

@Gaohan123 Gaohan123 added this to the v0.24.0 milestone Jun 18, 2026
@Gaohan123

Gaohan123 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

@wtomin @SamitHuang PTAL

wtomin
wtomin approved these changes Jun 24, 2026
View reviewed changes

@wtomin wtomin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fix looks good to me.

@wtomin wtomin added the ready label to trigger buildkite CI label Jun 24, 2026
@wtomin

wtomin commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

@yenuo26 I think this error message "ERROR tests/diffusion/models/glm_image/test_glm_image_sp.py - Failed: 'sp' not found in markers configuration option" is not relevant to this PR. Please check it.

@wtomin wtomin added ready label to trigger buildkite CI and removed ready label to trigger buildkite CI labels Jun 25, 2026
@wtomin
wtomin merged commit 0fd2620 into vllm-project:main Jun 25, 2026
9 checks passed
@moisf56 moisf56 mentioned this pull request Jun 25, 2026
Merged
@zwhzzz0821 zwhzzz0821 mentioned this pull request Jun 25, 2026
Merged
khairulkabir1661 pushed a commit to khairulkabir1661/vllm-omni that referenced this pull request Sep 25, 2026
@menjiantong menjiantong @wtomin
[BugFix] Fix MammothModa2 Text-to-Image Bug (vllm-project#4299)
c62dd30 
Signed-off-by: menjiantong <menjiantong@foxmail.com>
Co-authored-by: menjiantong <menjiantong@foxmail.com>
Co-authored-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsliuustc0106 hsliuustc0106 hsliuustc0106 left review comments
@wtomin wtomin wtomin approved these changes
@tzhouam tzhouam Awaiting requested review from tzhouam tzhouam is a code owner
@yuanheng-zhao yuanheng-zhao Awaiting requested review from yuanheng-zhao yuanheng-zhao is a code owner
@Isotr0py Isotr0py Awaiting requested review from Isotr0py
@princepride princepride Awaiting requested review from princepride
@SamitHuang SamitHuang Awaiting requested review from SamitHuang
@ZJY0516 ZJY0516 Awaiting requested review from ZJY0516
@RuixiangMa RuixiangMa Awaiting requested review from RuixiangMa
@david6666666 david6666666 Awaiting requested review from david6666666
@gcanlin gcanlin Awaiting requested review from gcanlin gcanlin is a code owner
@yenuo26 yenuo26 Awaiting requested review from yenuo26 yenuo26 is a code owner

Assignees

No one assigned

Labels

ready label to trigger buildkite CI

Projects

None yet

Milestone

v0.24.0

Development

Successfully merging this pull request may close these issues.

[Bug]: MammothModa2 Text-to-Image Generation Failed

4 participants

@menjiantong @Gaohan123 @wtomin @hsliuustc0106