[XPU][Rebase v0.22] Fix for 0.22 rebase#4059
Conversation
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 144d235e88
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if not current_platform.is_cuda(): | ||
| return marks + [test_distributed] |
There was a problem hiding this comment.
When this helper is evaluated on a non-CUDA host it now returns only marker tags, with no skipif. For multi-platform tests where the other platform helpers also do not add a skip on the current host (for example test_qwen2_5_omni_expansion.py on a CPU-only or otherwise unsupported runner), the test is collected with no active skip and will try to start the large hardware-only model instead of being skipped. The intended XPU fix needs a cross-platform skip only when the current platform is not any of the resources requested, while still avoiding CUDA's skip from suppressing XPU runs.
Useful? React with 👍 / 👎.
|
next time, please pay attention to the rebase PR, cc @tzhouam |
|
CI passed. @hsliuustc0106 |
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
Signed-off-by: Chendi Xue <chendi.xue@intel.com> Signed-off-by: akshatvishu <akshatnayak197@gmail.com>
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
2 participants
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Fix after 0.22 rebase
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)