Repository navigation
[Cleanup] Remove duplicate HiDreamI1ImagePipeline (fixes #4009) - #4045
Merged
hsliuustc0106 merged 3 commits intoJun 18, 2026
Merged
hsliuustc0106 merged 3 commits into
hsliuustc0106 merged 3 commits into
Conversation
…#4009) pipeline_hidream_i1_image.py is an exact duplicate of pipeline_hidream_image.py with only the class name differing. HiDreamI1ImagePipeline has zero external references — registry and __init__.py both use HiDreamImagePipeline exclusively. Signed-off-by: leo.yang <leo.yang.engineer@gmail.com>
yangyonggit
requested review from
Isotr0py,
RuixiangMa,
SamitHuang,
ZJY0516,
david6666666,
princepride and
wtomin
as code owners
June 1, 2026 10:32
hsliuustc0106
approved these changes
Jun 2, 2026
Collaborator
|
resolve conflicts |
…eam-i1-duplicate # Conflicts: # vllm_omni/diffusion/models/hidream_image/pipeline_hidream_i1_image.py
Contributor
Author
|
Conflict resolved |
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm-omni
that referenced
this pull request
Sep 25, 2026
…#4009) (vllm-project#4045) Signed-off-by: leo.yang <leo.yang.engineer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipeline_hidream_i1_image.py is an exact duplicate of pipeline_hidream_image.py with only the class name differing. HiDreamI1ImagePipeline has zero external references — registry and init.py both use HiDreamImagePipeline exclusively.
Purpose
pipeline_hidream_i1_image.py is an exact duplicate of pipeline_hidream_image.py with only the class name differing (HiDreamI1ImagePipeline vs HiDreamImagePipeline). HiDreamI1ImagePipeline has zero external references — the registry and init.py both use HiDreamImagePipeline exclusively. Part of codebase cleanup audit #4009.
Test Plan
uvx ruff check vllm_omni/ --select F401,F821,F811
python -c "
import vllm_omni
from vllm_omni.diffusion.models.hidream_image import HiDreamImagePipeline
print('imports OK')
"
Test Result
All checks passed!
imports OK