[HunyuanImage][Perf] adapt to deploy config changes#3996
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
b690104 to
6e55a6b
Compare
Signed-off-by: dengyunyang <584797741@qq.com>
gcanlin
reviewed
May 30, 2026
| "server_params": { | ||
| "model": "tencent/HunyuanImage-3.0-Instruct", | ||
| "serve_args": { | ||
| "deploy-config": "../vllm_omni/deploy/hunyuan_image3_dit.yaml", |
Collaborator
There was a problem hiding this comment.
Maybe use absolute path for UX.
Contributor
Author
There was a problem hiding this comment.
This is equivalent to using an absolute path, because the benchmark sets the working directory to tests after launching the Omni process (
lishunyang12
approved these changes
May 30, 2026
Collaborator
|
Can you leave a issue to keep track of the issue you found for undesirable performance under |
1 task
Contributor
Author
track with #4000 |
gcanlin
approved these changes
May 30, 2026
5 tasks
86MaxCao
pushed a commit
to 86MaxCao/vllm-omni
that referenced
this pull request
Jun 4, 2026
Signed-off-by: dengyunyang <584797741@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
(1)Remove it from test-nightly.yaml. Actually, the current nightly tests never run it.
(2)Adapt it to
deploy_config(3)Not use fp8
Before:
run_diffusion_benchmark.py starts vLLM Omni via
stage_config+CLI.After:
run_diffusion_benchmark.py starts vLLM Omni via
deploy_config+CLI.These performance tests will run daily on H200 in local testing.
Known issue: further investigation is needed into why
TP2_SP2performance on H200 is below expectations.Test Plan
Test Result
tp4
tp2 + sp2
tp2 + cfgp2
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)