Skip to content

[HunyuanImage][Perf] adapt to deploy config changes#3996

Merged
gcanlin merged 1 commit into
vllm-project:mainfrom
Bounty-hunter:dit_perf
May 30, 2026
Merged

[HunyuanImage][Perf] adapt to deploy config changes#3996
gcanlin merged 1 commit into
vllm-project:mainfrom
Bounty-hunter:dit_perf

Conversation

@Bounty-hunter
Copy link
Copy Markdown
Contributor

@Bounty-hunter Bounty-hunter commented May 30, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

(1)Remove it from test-nightly.yaml. Actually, the current nightly tests never run it.
(2)Adapt it to deploy_config
(3)Not use fp8

Before:
run_diffusion_benchmark.py starts vLLM Omni via stage_config + CLI.

After:
run_diffusion_benchmark.py starts vLLM Omni via deploy_config + CLI.

These performance tests will run daily on H200 in local testing.

Known issue: further investigation is needed into why TP2_SP2 performance on H200 is below expectations.

Test Plan

pytest -s -v tests/dfx/perf/scripts/run_diffusion_benchmark.py --test-config-file tests/dfx/perf/tests/test_hunyuan_image_tp4.json
pytest -s -v tests/dfx/perf/scripts/run_diffusion_benchmark.py --test-config-file tests/dfx/perf/tests/test_hunyuan_image_tp2_sp2.json
pytest -s -v tests/dfx/perf/scripts/run_diffusion_benchmark.py --test-config-file tests/dfx/perf/tests/test_hunyuan_image_tp2_cfgp2.json

Test Result

tp4

image

tp2 + sp2

image

tp2 + cfgp2

image
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@Bounty-hunter Bounty-hunter requested a review from yenuo26 as a code owner May 30, 2026 02:56
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Signed-off-by: dengyunyang <584797741@qq.com>
@gcanlin gcanlin added the ready label to trigger buildkite CI label May 30, 2026
"server_params": {
"model": "tencent/HunyuanImage-3.0-Instruct",
"serve_args": {
"deploy-config": "../vllm_omni/deploy/hunyuan_image3_dit.yaml",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use absolute path for UX.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is equivalent to using an absolute path, because the benchmark sets the working directory to tests after launching the Omni process (

cwd=str(Path(__file__).parent.parent.parent.parent),
). Therefore, regardless of the directory from which pytest is executed, the deploy config can always be accessed correctly via the relative path.

@lishunyang12
Copy link
Copy Markdown
Collaborator

Can you leave a issue to keep track of the issue you found for undesirable performance under TP2+SP2?

@Bounty-hunter
Copy link
Copy Markdown
Contributor Author

Can you leave a issue to keep track of the issue you found for undesirable performance under TP2+SP2?

track with #4000

@gcanlin gcanlin merged commit 3b31728 into vllm-project:main May 30, 2026
7 of 8 checks passed
86MaxCao pushed a commit to 86MaxCao/vllm-omni that referenced this pull request Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants