Added GQA support for CUDNNAttention backend#3984
Open
MaciejBalaNV wants to merge 1 commit into
Open
Conversation
Signed-off-by: Maciej Bala <mbala@nvidia.com>
Contributor
Author
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds GQA support for
CUDNNAttentionBackend, similar to how SDPA was handled here: #3728Purpose
Enabling models to use
CUDNNAttentionBackendwith GQA. One example is Bagel, other is Cosmos3 that is being added here: #3454Test Plan
Since
CUDNNAttentionBackendor GQA for SDPA didn't contain any tests, not extending it here, since it's out of scope of the PR and the change is very simple.Test Result
No relevant test results
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)