[Cleanup] Enable stale advanced_model marker post-#1272 and fix typo#3712
Open
bitborne wants to merge 1 commit into
Open
[Cleanup] Enable stale advanced_model marker post-#1272 and fix typo#3712bitborne wants to merge 1 commit into
bitborne wants to merge 1 commit into
Conversation
…nd fix typo - Uncomment @pytest.mark.advanced_model in test_sequence_parallel.py since PR vllm-project#1272 has already been merged. - Fix 'implemnentation' -> 'implementation' in gguf_adapters/base.py Signed-off-by: Schatten <czhengt@qq.com>
bitborne
requested review from
Isotr0py,
RuixiangMa,
SamitHuang,
ZJY0516,
david6666666,
princepride,
wtomin and
yenuo26
as code owners
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
|
||
| # TODO: After PR#1272 is merged, add markers | ||
| # @pytest.mark.advanced_model | ||
| @pytest.mark.advanced_model |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two minor cleanup items found during codebase exploration:
Enable
@pytest.mark.advanced_modelmarkertests/diffusion/distributed/test_sequence_parallel.pyhad a TODO comment indicating that@pytest.mark.advanced_modelshould be uncommented after PR [Test] L2 & L3 Test Case Stratification Design for Omni Model #1272 is merged. Since [Test] L2 & L3 Test Case Stratification Design for Omni Model #1272 has already been merged, this marker is now enabled.Fix typo in gguf adapter
Fixed
implemnentation→implementationinvllm_omni/diffusion/model_loader/gguf_adapters/base.py.Changes
tests/diffusion/distributed/test_sequence_parallel.py: Removed TODO comment and uncommented@pytest.mark.advanced_modelvllm_omni/diffusion/model_loader/gguf_adapters/base.py: Fixed spelling typo in FIXME commentSigned-off-by: Schatten czhengt@qq.com