Skip to content

[BugFix] Probe __dict__ instead of hasattr when patching WanRMS_norm #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gaohan123 merged 1 commit into from
May 7, 2026
Merged

[BugFix] Probe __dict__ instead of hasattr when patching WanRMS_norm #3400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions vllm_omni/diffusion/models/wan2_2/patch_diffusers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@
def patch_wan_rms_norm():
"""Patch diffusers Wan RMSNorm implementation with RMSNormVAE."""

# NOTE: iterate over a snapshot of sys.modules. `hasattr` can trigger lazy
# submodule imports (e.g. transformers' `_LazyModule.__getattr__`), which
# mutate sys.modules during iteration and raise
# `RuntimeError: dictionary changed size during iteration`.
for module_name, module in list(sys.modules.items()):
if hasattr(module, "WanRMS_norm"):
setattr(module, "WanRMS_norm", RMSNormVAE)
# Probe `__dict__` directly instead of `hasattr`: the latter triggers
# custom `__getattr__` hooks (e.g. transformers' image_processing alias
# modules), which both emit spurious deprecation warnings and can lazily
# import submodules, mutating sys.modules mid-iteration.
for module in list(sys.modules.values()):
module_dict = getattr(module, "__dict__", None)
if module_dict is not None and "WanRMS_norm" in module_dict:
module_dict["WanRMS_norm"] = RMSNormVAE
Loading