add support for MammothModa2 model#336
Conversation
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
For simplicity, most code of DiT stage is copied from https://github.com/bytedance/mammothmoda. These code will be simplified and reviewd after the pipeline running successfully. Signed-off-by: HonestDeng <2958906959@qq.com>
because preview version of mammothmoda2 only use last hidden state Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
|
Hi, will the model be ready before 1230 release? |
|
Yes. The MammothModa2-Preview is combined Qwen25-VL(with extra gen-experts in MLP layers) with an DiT module for image generation. Now I have already implemented the Qwen25-VL part of MammothModa2-Preview by reusing vllm code, such as Now I'm currently working on DiT parts. Hopefully I will finish DiT parts in this weekend and review my code before 1230. I'm not quite familiar in supporting new models. If there is any problem in my code, please correct me. Thanks! |
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
the model seems quite similar to Qwen-Image strcuture with a qwen-vl for encoding and a DiT module for image generation. |
I got an error when using huggingface id, PTAL. |
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
|
@HonestDeng pre-commit failed, PTAL |
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
|
Now huggingface id has been supported and pre-commit run successfully. |
Signed-off-by: HonestDeng <2958906959@qq.com>
Signed-off-by: HonestDeng <2958906959@qq.com>
38c123b to
b92d12f
Compare
princepride
left a comment
There was a problem hiding this comment.
Roughly LGTM, after testing, I will approve it.
Signed-off-by: HonestDeng <2958906959@qq.com>
Thanks |
|
Looks like good progress — active iteration with @hsliuustc0106 and @princepride. I'll defer to them on the remaining items. |
Later, we can move to v2.5 and fix the remaining issues |
Signed-off-by: HonestDeng <2958906959@qq.com> Signed-off-by: iwzbi <iwzbi@zju.edu.cn> Signed-off-by: iwzbi <wzbi@zju.edu.cn> Signed-off-by: Divyansh Singhvi <divyanshsinghvi@gmail.com> Signed-off-by: gcanlin <canlinguosdu@gmail.com> Signed-off-by: yinpeiqi <yinpeiqi809@gmail.com> Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com> Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com> Co-authored-by: catcat <108673086+iwzbi@users.noreply.github.com> Co-authored-by: iwzbi <iwzbi@zju.edu.cn> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com> Co-authored-by: dsinghvi <divyanshsinghvi@gmail.com> Co-authored-by: Canlin Guo <canlinguosdu@gmail.com> Co-authored-by: Peiqi Yin <60515999+yinpeiqi@users.noreply.github.com> Co-authored-by: 汪志鹏 <wangzhipeng628@gmail.com>
Signed-off-by: HonestDeng <2958906959@qq.com> Signed-off-by: iwzbi <iwzbi@zju.edu.cn> Signed-off-by: iwzbi <wzbi@zju.edu.cn> Signed-off-by: Divyansh Singhvi <divyanshsinghvi@gmail.com> Signed-off-by: gcanlin <canlinguosdu@gmail.com> Signed-off-by: yinpeiqi <yinpeiqi809@gmail.com> Signed-off-by: Hongsheng Liu <liuhongsheng4@huawei.com> Signed-off-by: 汪志鹏 <wangzhipeng628@gmail.com> Co-authored-by: catcat <108673086+iwzbi@users.noreply.github.com> Co-authored-by: iwzbi <iwzbi@zju.edu.cn> Co-authored-by: Hongsheng Liu <liuhongsheng4@huawei.com> Co-authored-by: dsinghvi <divyanshsinghvi@gmail.com> Co-authored-by: Canlin Guo <canlinguosdu@gmail.com> Co-authored-by: Peiqi Yin <60515999+yinpeiqi@users.noreply.github.com> Co-authored-by: 汪志鹏 <wangzhipeng628@gmail.com>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Resolve #314 , add support for MammothModa2 model https://github.com/bytedance/mammothmoda
Test Plan
Machine:
Parallel:
Image:
Machine:
Parallel:
Image:
Test Result
Image in the left side is generated by MammothModa2 official implementation while the right side from vllm-omni:

This table shows performance in two implementations:
Transfer time: 4.012ms
We get better performance.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)