-
Notifications
You must be signed in to change notification settings - Fork 1k
[perf]Qwen3-Omni performance optimization #3203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+414
−99
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b6192d2
Add text-only performance test cases for vllm
amy-why-3459 4b8df56
[perf]Qwen3-Omni performance optimization (#3164)
amy-why-3459 77f1f27
Merge branch 'main' into perf
hsliuustc0106 e56af85
Merge branch 'main' into perf
amy-why-3459 b434cc6
Merge branch 'main' into perf
amy-why-3459 1665329
Merge branch 'main' into perf
hsliuustc0106 e0ca2ca
Merge branch 'main' into perf
amy-why-3459 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| from types import SimpleNamespace | ||
|
|
||
| import pytest | ||
|
|
||
| from vllm_omni.worker.gpu_ar_model_runner import GPUARModelRunner | ||
|
|
||
| pytestmark = [pytest.mark.core_model, pytest.mark.cpu] | ||
|
|
||
|
|
||
| def _make_runner(engine_output_type: str | None, downstream_req_ids: set[str]) -> GPUARModelRunner: | ||
| runner = object.__new__(GPUARModelRunner) | ||
| runner.vllm_config = SimpleNamespace( | ||
| model_config=SimpleNamespace(engine_output_type=engine_output_type), | ||
| ) | ||
| runner._request_needs_downstream_stage_payload = lambda rid: rid in downstream_req_ids | ||
| return runner | ||
|
|
||
|
|
||
| def test_resolve_pooler_payload_req_ids_audio_terminal_stage_keeps_payload(): | ||
| runner = _make_runner(engine_output_type="audio", downstream_req_ids=set()) | ||
|
|
||
| engine_output_type, payload_req_ids = GPUARModelRunner._resolve_pooler_payload_req_ids(runner, ["r1", "r2"]) | ||
|
|
||
| assert engine_output_type == "audio" | ||
| assert payload_req_ids == ["r1", "r2"] | ||
|
|
||
|
|
||
| def test_resolve_pooler_payload_req_ids_text_terminal_stage_drops_payload(): | ||
| runner = _make_runner(engine_output_type="text", downstream_req_ids=set()) | ||
|
|
||
| engine_output_type, payload_req_ids = GPUARModelRunner._resolve_pooler_payload_req_ids(runner, ["r1", "r2"]) | ||
|
|
||
| assert engine_output_type == "text" | ||
| assert payload_req_ids == [] | ||
|
|
||
|
|
||
| def test_resolve_pooler_payload_req_ids_downstream_stage_uses_filtered_requests(): | ||
| runner = _make_runner(engine_output_type="latent", downstream_req_ids={"r2"}) | ||
|
|
||
| engine_output_type, payload_req_ids = GPUARModelRunner._resolve_pooler_payload_req_ids(runner, ["r1", "r2", "r3"]) | ||
|
|
||
| assert engine_output_type == "latent" | ||
| assert payload_req_ids == ["r2"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
use_omnitoserver_parammakescreate_unique_server_paramsemit 6-tuples, butcreate_reliability_omni_server_paramsin the same file still unpacks each entry as 5 values. When reliability tests initializeQWEN_PARAMS/WAN_PARAMS, this now raisesValueError: too many values to unpack, so those suites fail before running any test logic.Useful? React with 👍 / 👎.