-
Notifications
You must be signed in to change notification settings - Fork 950
[Refactor] Remove redundant StageDeployConfig fields, delegate to vLLM defaults #3128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gcanlin
wants to merge
18
commits into
vllm-project:main
Choose a base branch
from
gcanlin:pipeline-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e69079d
[Refactor] Remove redundant StageDeployConfig fields, delegate to vLL…
gcanlin 8090a08
fix
gcanlin 7750057
fix
gcanlin 3a765d6
Merge branch 'main' into pipeline-clean
gcanlin 177d1d3
fix
gcanlin f7074a9
unify qwen3-omni config
gcanlin 4d034b3
Merge branch 'main' into pipeline-clean
gcanlin 491b09a
Merge branch 'main' into pipeline-clean
gcanlin a6d4eb4
Merge branch 'main' into pipeline-clean
Gaohan123 f3441dc
Merge branch 'main' into pipeline-clean
gcanlin 3ccf735
revert
gcanlin b1b072f
Merge branch 'main' into pipeline-clean
gcanlin df78402
fix
gcanlin b5b7b43
Merge branch 'main' into pipeline-clean
hsliuustc0106 1c32d30
fix
gcanlin bc0b11e
fix
gcanlin 8c71834
Merge branch 'main' into pipeline-clean
gcanlin e866167
fix acc
gcanlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yenuo26 raised this on the previous diff — the inline path resolution was moved into conftest's
create_unique_server_paramsinstead of usingget_deploy_config_pathdirectly here. Worth a quick reply to close the loop.