[Bugfix] Fix default sampling params for /v1/videos on main#3049
Merged
hsliuustc0106 merged 3 commits intovllm-project:mainfrom Apr 23, 2026
Merged
Conversation
Signed-off-by: david6666666 <530634352@qq.com>
Collaborator
Author
wan22_bench_out.mp4 |
Signed-off-by: david6666666 <530634352@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/videosand/v1/videos/syncsampling params from the engine stage defaults before request overrides--default-sampling-paramsValidation
pre-commit run --all-filespytest -q tests/entrypoints/openai_api/test_video_server.py -k 'default_sampling_params_apply_to_video_requests or request_params_override_default_video_sampling_params or sync_default_sampling_params_apply_to_video_requests or frame_interpolation_params_pass_to_diffusion_sampling_params or sync_frame_interpolation_params_pass_to_sampling_params or sync_sampling_params_pass_through'vllm 0.19.0onWan-AI/Wan2.2-I2V-A14B-Diffusersusing:CUDA_VISIBLE_DEVICES=5,6 vllm serve ... --omni --port 8099 --enable-diffusion-pipeline-profiler --ulysses-degree 2 --default-sampling-params '{"0":{"enable_frame_interpolation":true,"frame_interpolation_exp":1,"frame_interpolation_scale":1.0,"frame_interpolation_model_path":"/mnt/data1/huggingface/hub/models--elfgum--RIFE-4.22.lite/snapshots/99d6892a9f4c039cb37ff21c9530e79b13f0b30b"}}'python curl_output/curl_w22_normal.pysteps=8 guidance=3.5 guidance_2=3.5 seed=42, and output MP4 hadaverage_rate=32.0for requestfps=16, confirming default frame interpolation still appliedFixes #3017.