[Cleanup] Drop empty _DIFFUSION_PIPELINES placeholder#3040
Merged
lishunyang12 merged 2 commits intovllm-project:mainfrom Apr 26, 2026
Merged
Conversation
…t#2987) Signed-off-by: lishunyang <lishunyang12@163.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
hsliuustc0106
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup to closing #2987. The empty
_DIFFUSION_PIPELINESslot invllm_omni/config/pipeline_registry.pywas added in #2915 with the comment "populated in PR 3/N" — that PR (#2987, single-stage diffusion migration) was closed in favor of deferring until DiT/VAE actually splits per #3038.With #2987 deferred, the placeholder is dead code and the comment references a closed PR. The 16 image diffusion models continue to work via the
_create_default_diffusion_stage_cfgfallback inasync_omni_engine.pyexactly as they always have.