Skip to content

[Bugfix] treewide: drop references to librosa#2996

Merged
linyueqian merged 2 commits intovllm-project:mainfrom
NickCao:librosa-again
Apr 21, 2026
Merged

[Bugfix] treewide: drop references to librosa#2996
linyueqian merged 2 commits intovllm-project:mainfrom
NickCao:librosa-again

Conversation

@NickCao
Copy link
Copy Markdown
Contributor

@NickCao NickCao commented Apr 21, 2026

Purpose

Continuation of #2273

Test Plan

examples/offline_inference/ming_flash_omni/end2end.py
tests/model_executor/models/voxcpm2/test_talker_state_eviction.py

Test Result

TBD


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: Nick Cao <ncao@redhat.com>
@NickCao NickCao requested a review from hsliuustc0106 as a code owner April 21, 2026 14:05
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Signed-off-by: Nick Cao <ncao@redhat.com>
@yuanheng-zhao
Copy link
Copy Markdown
Contributor

yuanheng-zhao commented Apr 21, 2026

Is this PR a followup fix for #2958 ?

PTAL @linyueqian , @lishunyang12

@NickCao
Copy link
Copy Markdown
Contributor Author

NickCao commented Apr 21, 2026

Is this PR a followup fix for #2958 ?

#1822 and #2720, the ruff rule should prevent this from happening again.

Copy link
Copy Markdown
Collaborator

@linyueqian linyueqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linyueqian linyueqian added the ready label to trigger buildkite CI label Apr 21, 2026
@linyueqian linyueqian enabled auto-merge (squash) April 21, 2026 14:37
@linyueqian linyueqian merged commit 339a6da into vllm-project:main Apr 21, 2026
8 checks passed
qinganrice pushed a commit to qinganrice/vllm-omni that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants