[Feature] Failure message shows more details#2961
Merged
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
There was a problem hiding this comment.
Pull request overview
Improves user-visible failure messages for orchestrator/engine crashes (e.g., OOM-related engine death) so clients receive clearer diagnostic context instead of a generic “orchestrator crashed” error.
Changes:
- Make AsyncOmni surface orchestrator error payloads as readable strings rather than dumping full dicts.
- Add richer context when orchestrator polling fails, and preserve chained exceptions for root-cause reporting.
- Cache and propagate an orchestrator crash reason through
AsyncOmniEngineoutput polling, with new unit tests covering the behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
vllm_omni/entrypoints/async_omni.py |
Raises a clearer RuntimeError message from orchestrator error payloads. |
vllm_omni/engine/stage_engine_core_proc.py |
Improves handshake failure error text when the stage core subprocess exits. |
vllm_omni/engine/orchestrator.py |
Wraps polling failures with more explicit component/stage context and exception chaining. |
vllm_omni/engine/async_omni_engine.py |
Adds crash-reason formatting, caches it, and uses it when the orchestrator is dead. |
tests/entrypoints/test_async_omni_abort.py |
Adds coverage for string error payload handling in _process_orchestrator_results. |
tests/engine/test_async_omni_engine_outputs.py |
Adds coverage for cached crash-reason propagation and formatter behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@amy-why-3459 @ZeldaHuang PTAL. |
Contributor
|
LGTM |
Collaborator
|
Solve conflicts. |
Signed-off-by: wuhang <wuhang6@huawei.com>
lishunyang12
approved these changes
Apr 22, 2026
qinganrice
pushed a commit
to qinganrice/vllm-omni
that referenced
this pull request
Apr 23, 2026
Signed-off-by: wuhang <wuhang6@huawei.com>
lengrongfu
pushed a commit
to lengrongfu/vllm-omni
that referenced
this pull request
May 1, 2026
Signed-off-by: wuhang <wuhang6@huawei.com>
clodaghwalsh17
pushed a commit
to clodaghwalsh17/nm-vllm-omni-ent
that referenced
this pull request
May 12, 2026
Signed-off-by: wuhang <wuhang6@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
#2392 's P1 fixing:
In the latest commit, OOM failures are now shown to the user, but the error message in the response isn’t very clear. This PR improves the message to make it clearer.
Test Plan
Start a serving instance of qwen3-tts, then hog the spare vram.
Burst 3 requests and see what respond.
Test Result
Before
After
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)