Skip to content

[BugFix] Preserve media access args for stage configs#2956

Merged
lishunyang12 merged 4 commits into
vllm-project:mainfrom
xiaohajiayou:bugfix/issue-2943-allowed-local-media-path
Apr 23, 2026
Merged

[BugFix] Preserve media access args for stage configs#2956
lishunyang12 merged 4 commits into
vllm-project:mainfrom
xiaohajiayou:bugfix/issue-2943-allowed-local-media-path

Conversation

@xiaohajiayou
Copy link
Copy Markdown
Contributor

@xiaohajiayou xiaohajiayou commented Apr 20, 2026

Purpose

Fix #2943

This fixes --allowed-local-media-path not taking effect for Qwen3-TTS Base requests when the service is started with --stage-configs-path.

The root cause was that AsyncOmniEngine._strip_single_engine_args() stripped inherited parent EngineArgs fields before stage config resolution, which unintentionally dropped:

  • allowed_local_media_path
  • allowed_media_domains

As a result, the per-stage model config never saw those media access settings, and local file://... reference audio was rejected even though --allowed-local-media-path had been provided.

Changes

  • keep allowed_local_media_path and allowed_media_domains in _PARENT_ARGS_KEEP
  • add a regression test covering preservation of these media access control args through parent arg stripping

Test Plan

  • Add a regression test to make sure allowed_local_media_path and allowed_media_domains are not stripped when using --stage-configs-path.
  • Verify the fix locally by starting a Qwen3-TTS Base service and sending a request with a local file:// reference audio.

Test Result

  • Ran python -m pytest tests/test_config_factory.py -k allowed_media_access_controls locally, and it passed.
  • Also verified the fix locally with a real Qwen3-TTS Base service started with --stage-configs-path and --allowed-local-media-path /root/vllm-omni.
  • Sent a /v1/audio/speech request with ref_audio=file:///root/vllm-omni/issue2943_ref.wav, got 200 OK, and the generated audio was written to /root/vllm-omni/issue2943_output.wav.

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: xiaohajiayou <923390377@qq.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@xiaohajiayou
Copy link
Copy Markdown
Contributor Author

Could you please take a look at whether this PR can be merged? Before the YAML refactor and migration are completed, this PR is still needed.
@lishunyang12

@lishunyang12 lishunyang12 merged commit d14ea37 into vllm-project:main Apr 23, 2026
8 checks passed
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
)

Signed-off-by: xiaohajiayou <923390377@qq.com>
Co-authored-by: SYLAR <125541396+lishunyang12@users.noreply.github.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
)

Signed-off-by: xiaohajiayou <923390377@qq.com>
Co-authored-by: SYLAR <125541396+lishunyang12@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: allowed-local-media-path has no effect for Qwen3-TTS Base task (local ref_audio rejected)

2 participants