[BugFix] Preserve media access args for stage configs#2956
Merged
lishunyang12 merged 4 commits intoApr 23, 2026
Merged
Conversation
Signed-off-by: xiaohajiayou <923390377@qq.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
1 task
1 task
Contributor
Author
|
Could you please take a look at whether this PR can be merged? Before the YAML refactor and migration are completed, this PR is still needed. |
lishunyang12
approved these changes
Apr 23, 2026
clodaghwalsh17
pushed a commit
to clodaghwalsh17/nm-vllm-omni-ent
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #2943
This fixes
--allowed-local-media-pathnot taking effect for Qwen3-TTS Base requests when the service is started with--stage-configs-path.The root cause was that
AsyncOmniEngine._strip_single_engine_args()stripped inherited parentEngineArgsfields before stage config resolution, which unintentionally dropped:allowed_local_media_pathallowed_media_domainsAs a result, the per-stage model config never saw those media access settings, and local
file://...reference audio was rejected even though--allowed-local-media-pathhad been provided.Changes
allowed_local_media_pathandallowed_media_domainsin_PARENT_ARGS_KEEPTest Plan
allowed_local_media_pathandallowed_media_domainsare not stripped when using--stage-configs-path.file://reference audio.Test Result
python -m pytest tests/test_config_factory.py -k allowed_media_access_controlslocally, and it passed.--stage-configs-pathand--allowed-local-media-path /root/vllm-omni./v1/audio/speechrequest withref_audio=file:///root/vllm-omni/issue2943_ref.wav, got200 OK, and the generated audio was written to/root/vllm-omni/issue2943_output.wav.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)