[BugFix] add missing subtalker sampling config to Qwen3-TTS deploy YAML#2940
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: xiaohajiayou <923390377@qq.com>
ad86a93 to
8e64c7e
Compare
hsliuustc0106
left a comment
There was a problem hiding this comment.
BLOCKING:
- Test Coverage — Missing regression test for this bugfix. Please add a test that verifies subtalker_sampling_params are correctly passed from YAML through to talker_mtp() and used instead of hardcoded values.
Signed-off-by: xiaohajiayou <923390377@qq.com>
84e667a to
3a95d2c
Compare
|
Added two tests for this.
|
Head branch was pushed to by a user without write access
9fbcded to
39dfe42
Compare
39dfe42 to
3cebb96
Compare
Signed-off-by: xiaohajiayou <923390377@qq.com>
|
The previous test component was missing the corresponding subtalker sampling parameters, which caused the CI to fail. This has been fixed in 6f5a157. Could you please take another look to see if we can merge this PR? |
|
cc @linyueqian |
|
Late pass after merge, fix looks fine. A couple of things for a follow-up if you have time:
@xiaohajiayou any chance you'd have time to pick up a follow-up PR for these? Happy to help review. |
…ML (vllm-project#2940) Signed-off-by: xiaohajiayou <923390377@qq.com>
…ML (vllm-project#2940) Signed-off-by: xiaohajiayou <923390377@qq.com>
…ML (vllm-project#2940) Signed-off-by: xiaohajiayou <923390377@qq.com>
…ML (vllm-project#2940) Signed-off-by: xiaohajiayou <923390377@qq.com>
…ML (vllm-project#2940) Signed-off-by: xiaohajiayou <923390377@qq.com>
Purpose
Fix #2942
In some TTS models' talker stage, sampling happens both in the main LLM decoding path and a separate talker fast-path that generates discrete audio codes for the downstream code2wav stage.
talker_mtpstill used hard-coded sampling values.This PR adds stage-level
subtalker_sampling_paramssupport for Qwen3-TTS and wires those parameters into the talker MTP/code predictor path.Changes
subtalker_sampling_paramsto stage deploy/config plumbingsubtalker_sampling_paramsthroughStageDeployConfig -> OmniEngineArgs -> OmniModelConfigtalker_mtp()to use configured subtalker sampling params instead of hard-coded valuestalker_mtp()subtalker_sampling_paramsdefaults todeploy/qwen3_tts.yamlFish SpeechandQwen3-Omnitalker_mtp()implementations accept extra kwargs for runner compatibilityThis change makes the Qwen3-TTS subtalker sampling path configurable from deploy YAML and aligns the runtime behavior more closely with the model's official subtalker configuration semantics.
The compatibility changes for
Fish SpeechandQwen3-Omniare only to ensure the updated runner call path does not break those models.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)