[Redo][Log] Wire stat logging into AsyncOmniEngine matching AsyncLLM#2918
Open
gcanlin wants to merge 3 commits into
Open
[Redo][Log] Wire stat logging into AsyncOmniEngine matching AsyncLLM#2918gcanlin wants to merge 3 commits into
gcanlin wants to merge 3 commits into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Collaborator
|
@amy-why-3459 PTAL |
Contributor
|
Just wondering, what was the question from last time? |
Collaborator
Author
Before the log behavior is sync and slow the stage-stage data flow, so we observed that the batch of stage-2 can't be used fully. Now this PR is making it async to keep consistent with vLLM. |
Collaborator
Author
|
Perf Test passed. https://buildkite.com/vllm/vllm-omni/builds/7245/steps/canvas |
Contributor
|
Based on the test results, this PR still seems to have a significant impact on performance. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Redo #2551, which made Qwen3-Omni performance regression before. This PR is fixing the performance issue.
Test Plan
Run Omni Test.
Test Result
https://buildkite.com/vllm/vllm-omni/builds/7245/steps/canvas
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)