-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Model] Add HSDP support for LTX-2 #2899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3f2999c
[Feat] support HSDP for LTX-2
fywc 59688d7
Merge branch 'vllm-project:main' into support-ltx2-hsdp
fywc a134eeb
Add pytest markers for LTX2 model tests
fywc d95ff5e
Merge branch 'main' into support-ltx2-hsdp
fywc ac8c06c
fix: apply ruff format
fywc 3f2b2af
Merge branch 'main' into support-ltx2-hsdp
fywc 1e4660a
Merge branch 'main' into support-ltx2-hsdp
fywc d31ac98
Merge branch 'main' into support-ltx2-hsdp
fywc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import pytest | ||
| import torch.nn as nn | ||
|
|
||
| from vllm_omni.diffusion.models.ltx2.ltx2_transformer import LTX2VideoTransformer3DModel | ||
|
|
||
| pytestmark = [pytest.mark.core_model, pytest.mark.cpu] | ||
|
|
||
|
|
||
| def test_ltx2_exposes_hsdp_shard_conditions_for_transformer_blocks(): | ||
| model = object.__new__(LTX2VideoTransformer3DModel) | ||
| nn.Module.__init__(model) | ||
| model.transformer_blocks = nn.ModuleList([nn.Linear(4, 4) for _ in range(2)]) | ||
| model.norm_out = nn.LayerNorm(4) | ||
|
|
||
| conditions = getattr(model, "_hsdp_shard_conditions", None) | ||
|
|
||
| assert conditions is not None | ||
| assert len(conditions) == 1 | ||
|
|
||
| matched = [] | ||
| for name, module in model.named_modules(): | ||
| if any(cond(name, module) for cond in conditions): | ||
| matched.append(name) | ||
|
|
||
| assert matched == ["transformer_blocks.0", "transformer_blocks.1"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.