[BugFix]: Fix Qwen3-TTS code2wav fails when enforce_eager: false#2868
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Fix looks correct. The tuple length check is defensive, which is good. One question: when enforce_eager: false, what returns an OmniOutput tuple instead of an OmniOutput object? Is it torch.compile or graph mode? Adding a comment explaining the root cause would help future maintainers understand why this conversion is needed. Also consider: could the check be stricter? For example, verify each tuple element type matches OmniOutput._field_types to catch mismatches earlier? |
|
why the RTF is so big >1? which hardware are you using? |
|
Please verify generated audio examples's quality. |
GPU: NVIDIA RTX 40 series |
Good advice! And I have test the quality, it seems no diffrence. The result is :
|
|
Good verification. Can you compare the performance when enable eager mode or not. And also consider the order of merging this PR and #2910 |
Sure,I am working on this. |
|
fix dco please. can you please update this pr before this friday? thanks. |
sure |
server start command before merge pr #2910:
After merge pr #2910:
|
Signed-off-by: wuyuefeng <565948592@qq.com>
bb1a036 to
16d91c6
Compare
Thanks for the reminder. I have fixed the missing DCO sign-off and updated the PR branch. |
…m-project#2868) Signed-off-by: wuyuefeng <565948592@qq.com>
…m-project#2868) Signed-off-by: wuyuefeng <565948592@qq.com>
Purpose
As described in PR #2866, this PR mainly fixes that issue.
This is also a review for PR #2328.
Test Plan
Test Result
The accuracy
Test Conclusion: Accuracy is satisfactory, and the content of the two audio segments is consistent.
When force_eager is false
output_force_eager_false.wav
When force_eager is true
output_force_eagler_true.wav
Performance (not as good as shown in the chart)
force_eager: falseforce_eager: true