Skip to content

[Fix][Fish Speech] Remove redundant get_vocab() in control token encoding #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linyueqian merged 1 commit into from
Apr 16, 2026
Merged

[Fix][Fish Speech] Remove redundant get_vocab() in control token encoding #2842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions vllm_omni/model_executor/models/fish_speech/prompt_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,7 @@ def _encode_plain_text(tokenizer: Any, text: str) -> list[int]:


def _encode_control_token(tokenizer: Any, token: str) -> list[int]:
vocab = tokenizer.get_vocab() if hasattr(tokenizer, "get_vocab") else {}
token_id = vocab.get(token)
if token_id is None:
token_id = tokenizer.convert_tokens_to_ids(token)
token_id = tokenizer.convert_tokens_to_ids(token)
if token_id is None or token_id == getattr(tokenizer, "unk_token_id", None):
raise ValueError(f"Fish Speech tokenizer is missing required control token: {token}")
return [int(token_id)]
Expand Down
Loading