Skip to content

CI: publish Omni images to a separate Docker Hub repository#2829

Merged
hsliuustc0106 merged 1 commit into
vllm-project:mainfrom
sheralskumar:new-omni-dockerhub
Apr 20, 2026
Merged

CI: publish Omni images to a separate Docker Hub repository#2829
hsliuustc0106 merged 1 commit into
vllm-project:mainfrom
sheralskumar:new-omni-dockerhub

Conversation

@sheralskumar

@sheralskumar sheralskumar commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Purpose

Point vLLM-Omni AMD hardware CI at a dedicated Docker Hub repository so Omni ROCm CI images are no longer published alongside core vLLM images under rocm/vllm-ci.

  • Build/push: .buildkite/test-template-amd-omni.j2: tag and push rocm/vllm-omni:$BUILDKITE_COMMIT.
  • Pull: .buildkite/scripts/hardware_ci/run-amd-test.sh: pull rocm/vllm-omni:${BUILDKITE_COMMIT} so test steps use the same image as the AMD build step.

The image tag is the commit SHA only (no -rocm-omni suffix), since the repository name already scopes Omni.

Test Plan

  • CI: After merge, confirm a build that runs the AMD Buildkite path: the amd-build step builds and pushes to rocm/vllm-omni:<commit>, and subsequent AMD GPU steps successfully docker pull that image and run tests.

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@sheralskumar

Copy link
Copy Markdown
Contributor Author

@tjtanaa would you please review? Thank you.

@tjtanaa

tjtanaa commented Apr 15, 2026

Copy link
Copy Markdown
Member

Thanks. Let me run some tests with this new changes.

@hsliuustc0106

Copy link
Copy Markdown
Collaborator

CI-only change, straightforward string replacement from rocm/vllm-ci to rocm/vllm-omni repository.

The test result checkbox is still pending. Before merge, please confirm:

  1. The new rocm/vllm-omni repository exists and is writable by the AMD CI pipeline
  2. No existing CI jobs or external workflows depend on pulling from rocm/vllm-ci:commit-rocm-omni

The TODO comment about ECR Public Gallery should remain as a reminder for future migration.

@tjtanaa

tjtanaa commented Apr 16, 2026

Copy link
Copy Markdown
Member

I will revisit this again tonight to check if https://status.canonical.com/ usptream is restored.

@tjtanaa tjtanaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lishunyang12 lishunyang12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The change is consistent across both files:

  • test-template-amd-omni.j2: The build step tags and pushes to rocm/vllm-omni:$BUILDKITE_COMMIT (was rocm/vllm-ci:$BUILDKITE_COMMIT-rocm-omni).
  • run-amd-test.sh: The pull step uses rocm/vllm-omni:${BUILDKITE_COMMIT} (was rocm/vllm-ci:${BUILDKITE_COMMIT}-rocm-omni).

The repository rename properly scopes Omni images away from core vLLM, and dropping the -rocm-omni tag suffix makes sense since the repo name already disambiguates. CI evidence in the PR description confirms the pipeline works end-to-end.

@gcanlin gcanlin added the ready label to trigger buildkite CI label Apr 20, 2026
@gcanlin gcanlin enabled auto-merge (squash) April 20, 2026 06:08
…m-omni, instead of rocm/vllm-ci

Signed-off-by: Sheral Kumar <shekumar@amd.com>
auto-merge was automatically disabled April 20, 2026 12:46

Head branch was pushed to by a user without write access

@hsliuustc0106 hsliuustc0106 merged commit 461bddc into vllm-project:main Apr 20, 2026
2 of 6 checks passed
nainiu258 pushed a commit to nainiu258/vllm-omni that referenced this pull request Apr 21, 2026
…ject#2829)

Signed-off-by: Sheral Kumar <shekumar@amd.com>
Signed-off-by: nainiu258 <cperfect02@163.com>
qinganrice pushed a commit to qinganrice/vllm-omni that referenced this pull request Apr 23, 2026
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
daixinning pushed a commit to daixinning/vllm-omni that referenced this pull request May 28, 2026
quyifei23 pushed a commit to quyifei23/vllm-omni that referenced this pull request Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants