CI: publish Omni images to a separate Docker Hub repository#2829
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@tjtanaa would you please review? Thank you. |
f0bb5a3 to
3688ef1
Compare
|
Thanks. Let me run some tests with this new changes. |
|
CI-only change, straightforward string replacement from rocm/vllm-ci to rocm/vllm-omni repository. The test result checkbox is still pending. Before merge, please confirm:
The TODO comment about ECR Public Gallery should remain as a reminder for future migration. |
|
I will revisit this again tonight to check if https://status.canonical.com/ usptream is restored. |
tjtanaa
left a comment
There was a problem hiding this comment.
LGTM @hsliuustc0106 @sheralskumar , the changes are validated, this is the build result https://buildkite.com/vllm/vllm-omni-amd-ci/builds/5417/steps/canvas
lishunyang12
left a comment
There was a problem hiding this comment.
LGTM. The change is consistent across both files:
test-template-amd-omni.j2: The build step tags and pushes torocm/vllm-omni:$BUILDKITE_COMMIT(wasrocm/vllm-ci:$BUILDKITE_COMMIT-rocm-omni).run-amd-test.sh: The pull step usesrocm/vllm-omni:${BUILDKITE_COMMIT}(wasrocm/vllm-ci:${BUILDKITE_COMMIT}-rocm-omni).
The repository rename properly scopes Omni images away from core vLLM, and dropping the -rocm-omni tag suffix makes sense since the repo name already disambiguates. CI evidence in the PR description confirms the pipeline works end-to-end.
…m-omni, instead of rocm/vllm-ci Signed-off-by: Sheral Kumar <shekumar@amd.com>
Head branch was pushed to by a user without write access
c68a64d to
2d1f109
Compare
…ject#2829) Signed-off-by: Sheral Kumar <shekumar@amd.com> Signed-off-by: nainiu258 <cperfect02@163.com>
…ject#2829) Signed-off-by: Sheral Kumar <shekumar@amd.com>
…ject#2829) Signed-off-by: Sheral Kumar <shekumar@amd.com>
…ject#2829) Signed-off-by: Sheral Kumar <shekumar@amd.com>
…ject#2829) Signed-off-by: Sheral Kumar <shekumar@amd.com>
…ject#2829) Signed-off-by: Sheral Kumar <shekumar@amd.com>
Purpose
Point vLLM-Omni AMD hardware CI at a dedicated Docker Hub repository so Omni ROCm CI images are no longer published alongside core vLLM images under
rocm/vllm-ci..buildkite/test-template-amd-omni.j2: tag and pushrocm/vllm-omni:$BUILDKITE_COMMIT..buildkite/scripts/hardware_ci/run-amd-test.sh: pullrocm/vllm-omni:${BUILDKITE_COMMIT}so test steps use the same image as the AMD build step.The image tag is the commit SHA only (no
-rocm-omnisuffix), since the repository name already scopes Omni.Test Plan
amd-buildstep builds and pushes torocm/vllm-omni:<commit>, and subsequent AMD GPU steps successfullydocker pullthat image and run tests.Test Result
rocm/vllm-omni. (https://buildkite.com/vllm/vllm-omni-amd-ci/builds/5417/steps/canvas and https://hub.docker.com/repository/docker/rocm/vllm-omni/tags/3688ef1a6be0cb0b30f4edbb10092970195cb113/sha256-bc25394e7ccc453324febe5429306cfce3404bd4f16d25c0147c298e847b6566)Essential Elements of an Effective PR Description Checklist