Skip to content

[BugFix] Fix NoneType' object has no attribute 'detach' #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linyueqian merged 1 commit into from
Apr 14, 2026
+6 −7
Merged

[BugFix] Fix NoneType' object has no attribute 'detach' #2797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/online_serving/test_qwen3_omni.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def test_mix_to_text_audio_001(omni_server, openai_client) -> None:
}

# Test single completion
openai_client.send_omni_request(request_config)
openai_client.send_omni_request(request_config, request_num=get_max_batch_size())


@pytest.mark.advanced_model
Expand Down
11 changes: 5 additions & 6 deletions vllm_omni/worker/gpu_ar_model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,12 +797,11 @@ def propose_draft_token_ids(sampled_token_ids):
elif isinstance(v, dict):
mm_payload[k] = {sk: sv[start:end].contiguous() for sk, sv in v.items()}
elif isinstance(v, list):
if idx < len(v):
element = v[idx]
if element is not None:
if isinstance(element, torch.Tensor):
element = element.clone()
mm_payload[k] = element
element = v[idx] if idx < len(v) else v[0]
Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also sync the code to NPUARModelRunner please?

Copy link
Copy Markdown
Contributor Author

@amy-why-3459 amy-why-3459 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was modified in this PR #2690, and it was found that npu_ar_model_runner.py was not modified, so NPU does not need to be modified.

element = v[idx] if idx < len(v) else v[0]
# Clone tensors to avoid cross-request aliasing
if isinstance(element, torch.Tensor):
    element = element.clone()
mm_payload[k] = element

if element is not None:
if isinstance(element, torch.Tensor):
element = element.clone()
mm_payload[k] = element
# Skip None elements: msgspec cannot serialize None
# in dict[str, torch.Tensor] typed fields.
elif isinstance(v, torch.Tensor):
Expand Down
Loading