Skip to content

[Misc] clean Temporary CI Configs#2784

Merged
Gaohan123 merged 2 commits into
vllm-project:mainfrom
n1ptune:fix-clean-temp-ci-configs
Apr 14, 2026
Merged

[Misc] clean Temporary CI Configs#2784
Gaohan123 merged 2 commits into
vllm-project:mainfrom
n1ptune:fix-clean-temp-ci-configs

Conversation

@n1ptune
Copy link
Copy Markdown
Contributor

@n1ptune n1ptune commented Apr 14, 2026

Purpose

Fixes #2755.

This PR prevents temporary stage config files generated during test runs from being left behind in the working tree. The affected test fixtures now keep generated config files under pytest-managed temporary paths and/or clean them up after the fixture finishes, so running tests no longer pollutes tests/e2e/stage_configs or tests/dfx/stability/stage_configs with untracked CI config files.

Test Plan

Ran the targeted test collection command and checked whether temporary stage config files were left in the working tree:

python -m pytest --collect-only -q tests/e2e/online_serving/test_qwen2_5_omni.py
git status --short -- tests/e2e/stage_configs tests/dfx/stability/stage_configs

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: neptune <neptune@hust.edu.cn>
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@hsliuustc0106 hsliuustc0106 requested a review from yenuo26 April 14, 2026 11:52
Copy link
Copy Markdown
Collaborator

@yenuo26 yenuo26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gaohan123 Gaohan123 added the ready label to trigger buildkite CI label Apr 14, 2026
Copy link
Copy Markdown
Collaborator

@Gaohan123 Gaohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Gaohan123 Gaohan123 added this to the v0.20.0 milestone Apr 14, 2026
@Gaohan123 Gaohan123 enabled auto-merge (squash) April 14, 2026 12:16
@Gaohan123 Gaohan123 merged commit bcd5f16 into vllm-project:main Apr 14, 2026
8 checks passed
y123456y78 pushed a commit to y123456y78/vllm-omni that referenced this pull request Apr 15, 2026
Signed-off-by: neptune <neptune@hust.edu.cn>
Co-authored-by: neptune <neptune@hust.edu.cn>
lvliang-intel pushed a commit to lvliang-intel/vllm-omni that referenced this pull request Apr 20, 2026
Signed-off-by: neptune <neptune@hust.edu.cn>
Co-authored-by: neptune <neptune@hust.edu.cn>
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
Signed-off-by: neptune <neptune@hust.edu.cn>
Co-authored-by: neptune <neptune@hust.edu.cn>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
Signed-off-by: neptune <neptune@hust.edu.cn>
Co-authored-by: neptune <neptune@hust.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests Leave Lots of Temporary CI Configs

3 participants