Skip to content

[Don't Merge][CLI] Add default generator device argument#2769

Closed
gcanlin wants to merge 1 commit into
vllm-project:release/v0.18.0.post1from
gcanlin:device-cli
Closed

[Don't Merge][CLI] Add default generator device argument#2769
gcanlin wants to merge 1 commit into
vllm-project:release/v0.18.0.post1from
gcanlin:device-cli

Conversation

@gcanlin
Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin commented Apr 14, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@gcanlin gcanlin requested a review from hsliuustc0106 as a code owner April 14, 2026 04:25
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@hsliuustc0106
Copy link
Copy Markdown
Collaborator

BLOCKER scan:

OVERALL: NO BLOCKERS

VERDICT: COMMENT

Small suggestion: Consider adding a unit test for the default_generator_device fallback logic, similar to the generator_device tests in related PRs.

@gcanlin gcanlin changed the title [CLI] Add default generator device argument [Don't Merge][CLI] Add default generator device argument Apr 15, 2026
@gcanlin gcanlin closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants