Skip to content

[MUSA][Feat] Upgrade MATE to match CUDA/ROCm behavior on FA#2766

Merged
gcanlin merged 4 commits intovllm-project:mainfrom
yeahdongcn:xd/fa_mate_upgrade
Apr 23, 2026
Merged

[MUSA][Feat] Upgrade MATE to match CUDA/ROCm behavior on FA#2766
gcanlin merged 4 commits intovllm-project:mainfrom
yeahdongcn:xd/fa_mate_upgrade

Conversation

@yeahdongcn
Copy link
Copy Markdown
Contributor

@yeahdongcn yeahdongcn commented Apr 14, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Upgrade MATE to match CUDA/ROCm behavior on Flash Attention.

Test Plan

Regression tests.

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

@yeahdongcn yeahdongcn changed the title [Feat] Upgrade MATE to match CUDA/ROCm behavior on FA [MUSA][Feat] Upgrade MATE to match CUDA/ROCm behavior on FA Apr 14, 2026
@hsliuustc0106
Copy link
Copy Markdown
Collaborator

BLOCKER scan:

  • Correctness: PASS
  • Reliability/Safety: PASS
  • Breaking Changes: PASS
  • Test Coverage: PASS (MUSA CI should cover this)
  • Documentation: PASS (internal backend change)
  • Security: PASS

OVERALL: NO BLOCKERS

VERDICT: COMMENT

Note: The logic change in is_mate_available() looks correct - checking for either flash_attn_func or flash_attn_varlen_func is appropriate given the new flash_attn_interface import.

Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
@yeahdongcn yeahdongcn marked this pull request as ready for review April 22, 2026 12:32
Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcanlin gcanlin added the ready label to trigger buildkite CI label Apr 23, 2026
@gcanlin gcanlin enabled auto-merge (squash) April 23, 2026 02:49
@gcanlin gcanlin merged commit 8384dea into vllm-project:main Apr 23, 2026
8 checks passed
yeahdongcn added a commit to yeahdongcn/vllm-omni that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants