[CI/BugFix] Fix Flaky Test for Qwen Omni Perf#2754
Merged
Conversation
Signed-off-by: Alex Brooks <albrooks@redhat.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
|
#2389 |
Collaborator
|
BLOCKER scan:
OVERALL: NO BLOCKERS VERDICT: COMMENT Good catch on the TCP fragmentation issue. SSE parsing requires exact handling of whitespace - stripping can break the protocol. The comment explaining the issue is clear and helpful. |
Collaborator
|
@Gaohan123 @gcanlin @princepride Please help review whether this is ready to be merged. |
1 task
y123456y78
pushed a commit
to y123456y78/vllm-omni
that referenced
this pull request
Apr 15, 2026
Signed-off-by: Alex Brooks <albrooks@redhat.com>
lvliang-intel
pushed a commit
to lvliang-intel/vllm-omni
that referenced
this pull request
Apr 20, 2026
Signed-off-by: Alex Brooks <albrooks@redhat.com>
lengrongfu
pushed a commit
to lengrongfu/vllm-omni
that referenced
this pull request
May 1, 2026
Signed-off-by: Alex Brooks <albrooks@redhat.com>
clodaghwalsh17
pushed a commit
to clodaghwalsh17/nm-vllm-omni-ent
that referenced
this pull request
May 12, 2026
Signed-off-by: Alex Brooks <albrooks@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes the flaky test in the build linked here: #2752 #2389
Streaming requests in vLLM / vLLM Omni follow SSE specification. Since we largely send data, this mostly means that we are sending things like:
Importantly, the space after the
:does matter. In our performance script, we are currently.strip()ing all incoming chunks. This is the underlying cause of the erratic CI failures, because higher concurrency in streaming requests can lead to situations like this:When we encounter this case, add_chunks on the handler will add the stripped messages, i.e., giving
data:{JSON}\n\n. As a resultchunk = message.removeprefix("data: ")later in our script doesn't do anything, and it tries to decode the JSON with thedata:in front, which causes the parsing error.Reproducing it is a bit difficult, but I did log one of the failed requests out and did see the leading
data:on it when decoding failed. The best way to repro is likely with a higher concurrency config, e.g., runningpytest tests/dfx/perf/scripts/run_benchmark.py -swith the config path set to point to something like below:CC @tzhouam