[Fix] HunyuanImage-3.0: unify naming hunyuan_image_3 → hunyuan_image3#2712
Merged
Gaohan123 merged 1 commit intovllm-project:mainfrom Apr 15, 2026
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
0cc5d54 to
adc5559
Compare
Collaborator
hsliuustc0106
left a comment
There was a problem hiding this comment.
Two config files still use the old hunyuan_image_3 naming on this branch:
vllm_omni/model_executor/stage_configs/hunyuan_image_3_moe_2gpu.yamlvllm_omni/platforms/xpu/stage_configs/hunyuan_image_3_moe.yaml
Could you rename these for consistency?
ebf2d20 to
84d9137
Compare
Contributor
Author
|
@hsliuustc0106 update |
Gaohan123
reviewed
Apr 15, 2026
Collaborator
Gaohan123
left a comment
There was a problem hiding this comment.
Please globaly check if other scripts and docs are also modified
The upstream HF repo (tencent/HunyuanImage-3.0-Instruct) uses `hunyuan_image_3` (underscore before "3") in file names and imports, but vllm-omni's convention omits it (e.g. `glm_image`, `qwen2_5_omni`). The main branch currently mixes both spellings: directories use `hunyuan_image_3` while registry keys, stage config filenames, and test names already use `hunyuan_image3`. This causes 3 runtime crashes: 1. diffusion/models/hunyuan_image3/hunyuan_image3_transformer.py:77 2. diffusion/models/hunyuan_image3/hunyuan_image3_tokenizer.py:16 3. platforms/musa/platform.py:41 All fail with: ModuleNotFoundError: No module named 'vllm_omni.diffusion.models.hunyuan_image_3' This commit: - Renames diffusion/models/hunyuan_image_3/ → hunyuan_image3/ - Renames stage configs: hunyuan_image3_moe_dit.yaml → hunyuan_image3_t2i.yaml - Deletes obsolete hunyuan_image_3_moe.yaml - Fixes import path strings in registry.py, interface.py, musa/platform.py - Updates test_hunyuanimage3_text2img.py to reference renamed config Note: NPU/MUSA platform changes are string-only path fixes. The original paths were already broken at runtime. No NPU/MUSA hardware available for testing. Signed-off-by: TaffyOfficial <2324465096@qq.com>
84d9137 to
615f902
Compare
y123456y78
pushed a commit
to y123456y78/vllm-omni
that referenced
this pull request
Apr 15, 2026
lvliang-intel
pushed a commit
to lvliang-intel/vllm-omni
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix inconsistent naming
hunyuan_image_3→hunyuan_image3across the codebase.The upstream HF repo (tencent/HunyuanImage-3.0-Instruct) uses
hunyuan_image_3(underscore before "3") in file names and imports, butvllm-omni's convention omits it (e.g.
glm_image,qwen2_5_omni). The main branch currently mixes both spellings: directories usehunyuan_image_3while registry keys, stage config filenames, and test names already usehunyuan_image3. This causes 3 runtimecrashes:
diffusion/models/hunyuan_image3/hunyuan_image3_transformer.py:77diffusion/models/hunyuan_image3/hunyuan_image3_tokenizer.py:16platforms/musa/platform.py:41All fail with:
ModuleNotFoundError: No module named 'vllm_omni.diffusion.models.hunyuan_image_3'Changes:
diffusion/models/hunyuan_image_3/→hunyuan_image3/hunyuan_image3_moe_dit.yaml→hunyuan_image3_t2i.yamlhunyuan_image_3_moe.yamlregistry.py,interface.py,musa/platform.pytest_hunyuanimage3_text2img.pyto reference renamed configNote: NPU/MUSA platform changes are string-only path fixes. The original paths were already broken at runtime. No NPU/MUSA hardware
available for testing.
Test Plan
This is a pure rename + string fix. No new test scripts needed — the existing
test_hunyuanimage3_text2img.pyhas been updated toreference the renamed config path.
Verify no remaining broken references: