Skip to content

[ROCm] [CI] Fix environment issue#2708

Merged
gcanlin merged 6 commits into
vllm-project:mainfrom
EmbeddedLLM:fix-qwenci20260412
Apr 12, 2026
Merged

[ROCm] [CI] Fix environment issue#2708
gcanlin merged 6 commits into
vllm-project:mainfrom
EmbeddedLLM:fix-qwenci20260412

Conversation

@tjtanaa
Copy link
Copy Markdown
Contributor

@tjtanaa tjtanaa commented Apr 12, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

ROCm vLLM Omni docker image is missing ffmpeg dependencies.

CUDA vLLM Upstream already shipped with ffmpeg dependencies, that is why this vLLM Omni PR #2273 that removed the ffmpeg when removing the librosa dependency does not affect the CUDA CI test.

pyav is just a python wrapper for ffmpeg.

Test Plan

Run the Qwen3 TTS tests on CI to ensure they are passing.

Test Result

https://buildkite.com/vllm/vllm-omni-amd-ci/builds/5120/steps/canvas


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

tjtanaa added 5 commits April 12, 2026 04:16
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@tjtanaa tjtanaa requested a review from hsliuustc0106 as a code owner April 12, 2026 14:59
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcanlin gcanlin added the ready label to trigger buildkite CI label Apr 12, 2026
@gcanlin gcanlin enabled auto-merge (squash) April 12, 2026 15:05
@gcanlin gcanlin merged commit 2dce028 into vllm-project:main Apr 12, 2026
8 checks passed
daixinning pushed a commit to daixinning/vllm-omni that referenced this pull request Apr 13, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants