Skip to content

[Perf] Add Performance Test for Qwen-Image Step-Level Execution#2707

Merged
Gaohan123 merged 4 commits into
vllm-project:mainfrom
wtomin:test-step
Apr 15, 2026
Merged

[Perf] Add Performance Test for Qwen-Image Step-Level Execution#2707
Gaohan123 merged 4 commits into
vllm-project:mainfrom
wtomin:test-step

Conversation

@wtomin
Copy link
Copy Markdown
Collaborator

@wtomin wtomin commented Apr 12, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

To monitor the step-level execution feature's performance on Qwen-Image, we need to include this test case in nightly perf test.

Test Plan

pytest -s -v tests/dfx/perf/scripts/run_diffusion_benchmark.py --config-file tests/dfx/perf/tests/test_qwen_image_vllm_omni.json

Running it on CI machines (H100) . Results in buildkite.

Test Result

Test Resolution × steps latency_mean (s) latency_p50 (s) throughput_qps QwenImagePipeline.diffuse p50 (s)
test_qwen_image_single_device 512×512, 20 2.62 2.51 0.38 2.32
test_qwen_image_single_device 1536×1536, 35 24.45 24.43 0.04 23.19
test_qwen_image_single_device_step_execution 512×512, 20 2.48 2.48 0.40
test_qwen_image_single_device_step_execution 1536×1536, 35 24.46 24.42 0.04

Conclusion:
step_execution does not change end-to-end latency/throughput at the large resolution, and gives a small gain at the small resolution.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@wtomin wtomin added the nightly-test label to trigger buildkite nightly test CI label Apr 12, 2026
"name": "1536x1536_steps35",
"dataset": "random",
"task": "t2i",
"width": 1536,
Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we cover this issue #845 in the tests? Although it's a functional issue actually.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on whether we want to monitor its performance in the long run. I think currently, 1328x1328 is not our priority.

@hsliuustc0106
Copy link
Copy Markdown
Collaborator

PR description incomplete. Test Plan and Test Result sections are empty.

Please update with:

  • How baselines were derived (hardware, actual test run that produced these numbers)
  • Simple test showing this config runs successfully

@wtomin
Copy link
Copy Markdown
Collaborator Author

wtomin commented Apr 13, 2026

PR description incomplete. Test Plan and Test Result sections are empty.

Please update with:

  • How baselines were derived (hardware, actual test run that produced these numbers)
  • Simple test showing this config runs successfully

It has been updated.

@wtomin
Copy link
Copy Markdown
Collaborator Author

wtomin commented Apr 13, 2026

@asukaqaq-s Do this performance test and results look good to you? The results shown in this PR may not be compared directly to the results in #1769, because they might be obtained on different machines.

@asukaqaq-s
Copy link
Copy Markdown
Contributor

@asukaqaq-s Do this performance test and results look good to you? The results shown in this PR may not be compared directly to the results in #1769, because they might be obtained on different machines.

I think this conclusion is consistent with my tests: there is some performance improvement at low resolutions.

@wtomin
Copy link
Copy Markdown
Collaborator Author

wtomin commented Apr 13, 2026

I think nightly-gedit-bench-accuracy failed occasionly probably because the threshold is too tight. @david6666666 @yenuo26 Any comments?

@yenuo26
Copy link
Copy Markdown
Collaborator

yenuo26 commented Apr 13, 2026

I think nightly-gedit-bench-accuracy failed occasionly probably because the threshold is too tight. @david6666666 @yenuo26 Any comments?

#2644 this issue

@wtomin
Copy link
Copy Markdown
Collaborator Author

wtomin commented Apr 13, 2026

I think it's ready for merge. PTAL @hsliuustc0106 @Gaohan123 @fhfuih

wtomin added 2 commits April 15, 2026 15:34
Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
@Gaohan123 Gaohan123 added this to the v0.20.0 milestone Apr 15, 2026
@Gaohan123 Gaohan123 added ready label to trigger buildkite CI and removed nightly-test label to trigger buildkite nightly test CI labels Apr 15, 2026
Copy link
Copy Markdown
Collaborator

@Gaohan123 Gaohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Gaohan123 Gaohan123 enabled auto-merge (squash) April 15, 2026 16:44
@Gaohan123 Gaohan123 merged commit e958113 into vllm-project:main Apr 15, 2026
8 checks passed
y123456y78 pushed a commit to y123456y78/vllm-omni that referenced this pull request Apr 15, 2026
…-project#2707)

Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
y123456y78 pushed a commit to y123456y78/vllm-omni that referenced this pull request Apr 16, 2026
…-project#2707)

Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
lvliang-intel pushed a commit to lvliang-intel/vllm-omni that referenced this pull request Apr 20, 2026
…-project#2707)

Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
…-project#2707)

Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
…-project#2707)

Signed-off-by: Didan Deng <33117903+wtomin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants