Skip to content

[Bugfix] Fix UT for the missing of log_stats in Engine#2706

Merged
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
gcanlin:log-stats-ut
Apr 12, 2026
Merged

[Bugfix] Fix UT for the missing of log_stats in Engine#2706
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
gcanlin:log-stats-ut

Conversation

@gcanlin
Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin commented Apr 12, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Fix: https://buildkite.com/vllm/vllm-omni/builds/6416/steps/canvas

Because #2551 got merged without updating branch by the latest main, the #2519 introduced the new UT but #2551 didn't add the new field log_stats for the new UT.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@gcanlin gcanlin added the ready label to trigger buildkite CI label Apr 12, 2026
@hsliuustc0106 hsliuustc0106 merged commit 95b5b2e into vllm-project:main Apr 12, 2026
7 of 8 checks passed
daixinning pushed a commit to daixinning/vllm-omni that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants