[Bugfix] restore legacy stage config precedence#2663
Merged
hsliuustc0106 merged 1 commit intovllm-project:mainfrom Apr 10, 2026
Merged
Conversation
Signed-off-by: xiaohajiayou <923390377@qq.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
1 task
Sy0307
pushed a commit
to Sy0307/vllm-omni
that referenced
this pull request
Apr 10, 2026
Signed-off-by: xiaohajiayou <923390377@qq.com>
daixinning
pushed a commit
to daixinning/vllm-omni
that referenced
this pull request
Apr 13, 2026
Signed-off-by: xiaohajiayou <923390377@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
This PR fixes an unintended behavior introduced by #2076 in the legacy
load_and_resolve_stage_configspath.After #2076, CLI runtime args can override default stage configs. However,
CLI default values also started participating in the merge and could override
the YAML's default stage config values even when the user did not explicitly
set those CLI args.
This PR restores the previous behavior for the legacy loader by switching
prefer_stage_engine_argsback toTruewhen loading model-default stageconfigs.
Behavior
Before this fix:
After this fix:
Rationale
The affected path is the legacy
load_and_resolve_stage_configschain, whichis planned to be removed by the config refactor tracked in #2072.
this pr is a minimal rollback of the legacy precedence behavior, intended as a temporary fix until the #2072 refactor is completed.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)