Skip to content

[Bugfix] Assign original prompt back to RequestOutput#2498

Merged
princepride merged 1 commit into
vllm-project:mainfrom
yuanheng-zhao:fix/out-missing-prompt
Apr 5, 2026
Merged

[Bugfix] Assign original prompt back to RequestOutput#2498
princepride merged 1 commit into
vllm-project:mainfrom
yuanheng-zhao:fix/out-missing-prompt

Conversation

@yuanheng-zhao
Copy link
Copy Markdown
Collaborator

@yuanheng-zhao yuanheng-zhao commented Apr 5, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Resolves #2497

Test Plan

Ming e2e example test (any e2e test printing out RequestOutput.prompt

Test Result

Before this fix:

Prompt:
None
Text Output:
<think>
Okay, let's try to figure out

After

Prompt:
<role>SYSTEM</role>你是一个友好的AI助手。

detailed thinking on<|role_end|><role>HUMAN</role><IMAGE>Based on the following rules:
•       You control the smiley face character
•       You can move up, down, left, and right, and only a single square at a time
•       Walls are dark grey and cannot be moved into
•       The brown square is a box
•       The box can be pushed by moving into it (i.e., if you are in the square adjacent to the box to the left, and move onto the square with the box, the box will move one square to the right).
•       The box cannot be pushed into walls
•       The blue door at the bottom is locked and cannot be passed through, unless the box is placed on the blue square
•       The square beneath the blue door is the exit
•       Moving from one square to another

Let's assume a coordinate system where the smiley face is on the top left at (1,1) and the square below it is (1,2). The smiley face performs the following moves: {down, right, right, right}, such that the smiley face is at square (4,2) and the box is in square (5,2). What are the next sequence of moves that must be done to move the box down to (5,3)? Give your answer as a comma separated list.<|role_end|><role>ASSISTANT</role>
Text Output:
<think>
Okay, let's try to figure out the

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
@princepride princepride enabled auto-merge (squash) April 5, 2026 10:11
@princepride princepride added the ready label to trigger buildkite CI label Apr 5, 2026
Copy link
Copy Markdown
Collaborator

@princepride princepride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@princepride princepride merged commit 88f7ed9 into vllm-project:main Apr 5, 2026
8 checks passed
@yuanheng-zhao yuanheng-zhao deleted the fix/out-missing-prompt branch April 5, 2026 11:11
skf-1999 pushed a commit to Semmer2/vllm-omni that referenced this pull request Apr 7, 2026
)

Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
vraiti pushed a commit to vraiti/vllm-omni that referenced this pull request Apr 9, 2026
)

Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
)

Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
)

Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: RequestOutput.prompt is always None, input prompt is missing

2 participants