Skip to content

[Bugfix] Include uv.lock in .gitignore#2493

Merged
princepride merged 2 commits into
vllm-project:mainfrom
timzsu:uv-lock-ignore
Apr 5, 2026
Merged

[Bugfix] Include uv.lock in .gitignore#2493
princepride merged 2 commits into
vllm-project:mainfrom
timzsu:uv-lock-ignore

Conversation

@timzsu
Copy link
Copy Markdown
Contributor

@timzsu timzsu commented Apr 5, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

uv.lock should be included in .gitignore, so that a development environment can see a clean directory after installation. Following vLLM's .gitignore, this PR adds it to .gitignore.

Test Plan

N/A

Test Result

N/A


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: Zhengyuan Su (苏政渊) <su.zhengyuan@u.nus.edu>
@timzsu timzsu requested a review from hsliuustc0106 as a code owner April 5, 2026 07:17
@timzsu timzsu changed the title Include uv.lock in .gitignore [Bugfix] Include uv.lock in .gitignore Apr 5, 2026
@timzsu
Copy link
Copy Markdown
Contributor Author

timzsu commented Apr 5, 2026

@princepride Please have a look at this PR.

@princepride princepride added the ready label to trigger buildkite CI label Apr 5, 2026
Copy link
Copy Markdown
Collaborator

@princepride princepride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@princepride princepride enabled auto-merge (squash) April 5, 2026 07:20
@princepride princepride merged commit dd9ca6f into vllm-project:main Apr 5, 2026
5 of 6 checks passed
skf-1999 pushed a commit to Semmer2/vllm-omni that referenced this pull request Apr 7, 2026
Signed-off-by: Zhengyuan Su (苏政渊) <su.zhengyuan@u.nus.edu>
vraiti pushed a commit to vraiti/vllm-omni that referenced this pull request Apr 9, 2026
Signed-off-by: Zhengyuan Su (苏政渊) <su.zhengyuan@u.nus.edu>
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
Signed-off-by: Zhengyuan Su (苏政渊) <su.zhengyuan@u.nus.edu>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
Signed-off-by: Zhengyuan Su (苏政渊) <su.zhengyuan@u.nus.edu>
daixinning pushed a commit to daixinning/vllm-omni that referenced this pull request May 28, 2026
Signed-off-by: Zhengyuan Su (苏政渊) <su.zhengyuan@u.nus.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants