Skip to content

ci: remove CosyVoice3 post-merge test#2492

Merged
Gaohan123 merged 1 commit intovllm-project:mainfrom
linyueqian:ci/remove-cosyvoice3-post-merge-test
Apr 5, 2026
Merged

ci: remove CosyVoice3 post-merge test#2492
Gaohan123 merged 1 commit intovllm-project:mainfrom
linyueqian:ci/remove-cosyvoice3-post-merge-test

Conversation

@linyueqian
Copy link
Copy Markdown
Collaborator

@linyueqian linyueqian commented Apr 5, 2026

Summary

  • Remove CosyVoice3 post-merge (advanced_model) e2e test from test-merge.yml
  • Zero-shot voice cloning quality is too variable for ASR similarity checks
  • Pre-merge core_model tests already verify the pipeline produces audio

Test plan

  • CI passes without the post-merge test block

Signed-off-by: linyueqian <linyueqian@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Signed-off-by: linyueqian <linyueqian@outlook.com>
@linyueqian linyueqian force-pushed the ci/remove-cosyvoice3-post-merge-test branch from c39621b to 7effb8f Compare April 5, 2026 06:39
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

weighted_scores = weighted_scores.clone()
weighted_scores[top_id] = float("-inf")
fallback_probs = weighted_scores.softmax(dim=0)
top_id = int(cls._multinomial_sample(fallback_probs, generator=generator).item())

P1 Badge Skip RAS fallback when no alternative token exists

When repetition rejection triggers here, top_id is set to -inf and fallback sampling is always attempted. If constraints/logits processors leave only one valid token (for example an allowed_token_ids mask with a single id), this makes all logits -inf, so softmax becomes invalid and torch.multinomial can fail at runtime. This regression is introduced by the new model-side sampler path and can crash constrained CosyVoice3 decoding requests instead of returning a token.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Copy Markdown
Collaborator

@Gaohan123 Gaohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gaohan123 Gaohan123 merged commit 0824ede into vllm-project:main Apr 5, 2026
4 checks passed
skf-1999 pushed a commit to Semmer2/vllm-omni that referenced this pull request Apr 7, 2026
vraiti pushed a commit to vraiti/vllm-omni that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants