[Chore] Fix Bagel model import compatibility#2491
Conversation
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
|
Why could this test in CI pass? https://buildkite.com/vllm/vllm-omni/builds/5865/steps/canvas?sid=019d5b22-e3c6-467e-ab95-8ff38f44b359&tab=output |
@gcanlin Oh I just re-checked. It's an import warning rather than an actual ImportError (ImportError is from my another WIP branch, not relatable to this one). The CI didn't trigger from vllm.inputs import ModalityData, MultiModalDataDict, MultiModalUUIDDictAnd the current one will only report a warning like This PR should be a chore import cleanup. Updated PR title and desc. |
|
@yuanheng-zhao Thanks for investigating! |
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
vLLM version has been updated to
0.19.0but there's an import in Bagel left to be updated.vLLM
0.19.0https://github.com/vllm-project/vllm/blob/v0.19.0/vllm/multimodal/parse.py#L22 imports those classes fromvllm.inputsTo prevent export warning and keep future import clean, this PR updates the import path to utilize upstream
vllm.inputscc @princepride
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)