Skip to content

[Chore] Fix Bagel model import compatibility#2491

Merged
gcanlin merged 1 commit intovllm-project:mainfrom
yuanheng-zhao:fix/bagel-import
Apr 5, 2026
Merged

[Chore] Fix Bagel model import compatibility#2491
gcanlin merged 1 commit intovllm-project:mainfrom
yuanheng-zhao:fix/bagel-import

Conversation

@yuanheng-zhao
Copy link
Copy Markdown
Contributor

@yuanheng-zhao yuanheng-zhao commented Apr 5, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

vLLM version has been updated to 0.19.0 but there's an import in Bagel left to be updated.

vLLM 0.19.0 https://github.com/vllm-project/vllm/blob/v0.19.0/vllm/multimodal/parse.py#L22 imports those classes from vllm.inputs

from vllm.inputs import ModalityData, MultiModalDataDict, MultiModalUUIDDict

To prevent export warning and keep future import clean, this PR updates the import path to utilize upstream vllm.inputs

cc @princepride

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
@gcanlin
Copy link
Copy Markdown
Collaborator

gcanlin commented Apr 5, 2026

Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the change LGTM.

@yuanheng-zhao yuanheng-zhao changed the title [Bugfix] Fix Bagel model import compatibility [Chore] Fix Bagel model import compatibility Apr 5, 2026
@yuanheng-zhao
Copy link
Copy Markdown
Contributor Author

yuanheng-zhao commented Apr 5, 2026

Why could this test in CI pass? https://buildkite.com/vllm/vllm-omni/builds/5865/steps/canvas?sid=019d5b22-e3c6-467e-ab95-8ff38f44b359&tab=output

@gcanlin Oh I just re-checked. It's an import warning rather than an actual ImportError (ImportError is from my another WIP branch, not relatable to this one).

The CI didn't trigger ImportError because vLLM has a backward compatibility in https://github.com/vllm-project/vllm/blob/v0.19.0/vllm/multimodal/parse.py#L22 which imports those classes from vllm.inputs

from vllm.inputs import ModalityData, MultiModalDataDict, MultiModalUUIDDict

And the current one will only report a warning like

"ModalityData" is not exported from module "vllm.multimodal.parse"

This PR should be a chore import cleanup. Updated PR title and desc.

@gcanlin gcanlin added the ready label to trigger buildkite CI label Apr 5, 2026
@gcanlin
Copy link
Copy Markdown
Collaborator

gcanlin commented Apr 5, 2026

@yuanheng-zhao Thanks for investigating!

@gcanlin gcanlin enabled auto-merge (squash) April 5, 2026 06:18
@gcanlin gcanlin merged commit 094907e into vllm-project:main Apr 5, 2026
8 checks passed
@yuanheng-zhao yuanheng-zhao deleted the fix/bagel-import branch April 5, 2026 07:55
skf-1999 pushed a commit to Semmer2/vllm-omni that referenced this pull request Apr 7, 2026
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
vraiti pushed a commit to vraiti/vllm-omni that referenced this pull request Apr 9, 2026
Signed-off-by: Yuanheng Zhao <jonathan.zhaoyh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants