Add supports_float64() to OmniPlatform and clean up MPS#2488
Merged
gcanlin merged 1 commit intovllm-project:mainfrom Apr 7, 2026
Merged
Add supports_float64() to OmniPlatform and clean up MPS#2488gcanlin merged 1 commit intovllm-project:mainfrom
gcanlin merged 1 commit intovllm-project:mainfrom
Conversation
Contributor
Author
|
@gcanlin @hsliuustc0106 Please take a look when you are available? Thanks! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5740ada294
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
yeahdongcn
force-pushed
the
xd/add_supports_float64
branch
from
5740ada to
2fd9551
Compare
5 tasks
gcanlin
approved these changes
Apr 5, 2026
Collaborator
gcanlin
left a comment
gcanlin
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning up.
17 tasks
Collaborator
|
resolve conflicts |
Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
yeahdongcn
force-pushed
the
xd/add_supports_float64
branch
from
2fd9551 to
c2dff32
Compare
Contributor
Author
Done. |
vraiti
pushed a commit
to vraiti/vllm-omni
that referenced
this pull request
Apr 9, 2026
…#2488) Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
bob-021206
pushed a commit
to jasonlee-1024/vllm-omni
that referenced
this pull request
Apr 21, 2026
…#2488) Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com> Signed-off-by: bob-021206 <binyan_github@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Following the offline discussion in #2451, there were some comments regarding handling
float64dtype.BTW, I found
mpsis not supported invllm-omni, this PR also includes cleanup.Test Plan
Check if the code changes break tests on #2451 or not.
Test Result
Everything works fine.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)