[skip ci][doc]Update async_chunk design diagram#2420
Merged
Conversation
amy-why-3459
changed the title
amy-why-3459
force-pushed
the
bugfix
branch
2 times, most recently
from
95e476e to
fd71950
Compare
Contributor
Author
|
@R2-Y @Shirley125 PTAL |
R2-Y
reviewed
Apr 2, 2026
| [Thinker: ████████████████████] (2.0s) | ||
| [Talker: ████████████████████] (3.0s) | ||
| [Code2Wav: ████] (1.0s) | ||
| Total: 6.0s, TTFA: 6.0s |
Contributor
There was a problem hiding this comment.
maybe change TTFA to TTFP? consistent with qwen3-omni paper
| [Thinker: ████░░░░████░░░░████] (2.0s, streaming) | ||
| [Talker: ░░████░░░░████░░] (3.0s, parallel) | ||
| [Code2Wav: ░░░░████░░] (1.0s, batched) | ||
| Total: ~3.5s, TTFA: ~0.5s |
| **Diagram Legend:** | ||
| | Color | Stage Type | Description | | ||
| |:------|:-----------|:------------| | ||
| | 🟪 Pink (`prefill`) | Initialization | Context processing, KV cache initialization | |
Collaborator
There was a problem hiding this comment.
the color looks not the same as diagram
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
gcanlin
reviewed
Apr 11, 2026
Collaborator
gcanlin
left a comment
gcanlin
left a comment
There was a problem hiding this comment.
Curious, from the new diagram, the talker prefill is outputting the second text token. Is it expected? I don't understand it fully.
hsliuustc0106
approved these changes
Apr 13, 2026
hsliuustc0106
changed the title
Celeste-jq
pushed a commit
to IsleOfDawnlight/vllm-omni-voxcpm
that referenced
this pull request
Apr 14, 2026
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
lengrongfu
pushed a commit
to lengrongfu/vllm-omni
that referenced
this pull request
May 1, 2026
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
clodaghwalsh17
pushed a commit
to clodaghwalsh17/nm-vllm-omni-ent
that referenced
this pull request
May 12, 2026
Signed-off-by: amy-why-3459 <wuhaiyan17@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)