Skip to content

[Bugfix] Update Whisper model loading to support multi-GPU configurations and optimize CUDA memory management#2354

Merged
gcanlin merged 2 commits into
vllm-project:mainfrom
yenuo26:whisper
Mar 31, 2026
Merged

[Bugfix] Update Whisper model loading to support multi-GPU configurations and optimize CUDA memory management#2354
gcanlin merged 2 commits into
vllm-project:mainfrom
yenuo26:whisper

Conversation

@yenuo26
Copy link
Copy Markdown
Collaborator

@yenuo26 yenuo26 commented Mar 31, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

fix timeout error in nightly CI, update Whisper model loading to support multi-GPU configurations and optimize CUDA memory management
https://buildkite.com/vllm/vllm-omni/builds/5507/steps/canvas

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

…gurations and optimize CUDA memory management

Signed-off-by: wangyu <410167048@qq.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab8e5ff88d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread tests/conftest.py
@yenuo26
Copy link
Copy Markdown
Collaborator Author

yenuo26 commented Mar 31, 2026

@congw729 @gcanlin @Gaohan123 please help to add nightly-test label

@congw729 congw729 added the nightly-test label to trigger buildkite nightly test CI label Mar 31, 2026
@yenuo26
Copy link
Copy Markdown
Collaborator Author

yenuo26 commented Mar 31, 2026

before:
01dcdfbd-41c6-4793-b864-4a941bfb6a3b

after:
ff99ed55-decd-463d-abcf-c4193be291d2

The timeout issue has been resolved. The other error of "Omni Model Test with H100“ is being tracked in #1830, and the error of "Diffusion Model Test with H100
" is being tracked in #2350.

@congw729 @gcanlin please help to add ready label and remove nightly-test label

@congw729 congw729 added ready label to trigger buildkite CI and removed nightly-test label to trigger buildkite nightly test CI labels Mar 31, 2026
@yenuo26
Copy link
Copy Markdown
Collaborator Author

yenuo26 commented Mar 31, 2026

@gcanlin @Gaohan123 Please review whether this PR can be merged

Comment thread tests/conftest.py Outdated
…ariable and enhance audio processing with UUIDs

Signed-off-by: wangyu <410167048@qq.com>
@yenuo26 yenuo26 requested a review from hsliuustc0106 as a code owner March 31, 2026 10:41
@yenuo26 yenuo26 changed the title [Enhancement] Update Whisper model loading to support multi-GPU configurations and optimize CUDA memory management [Bugfix] Update Whisper model loading to support multi-GPU configurations and optimize CUDA memory management Mar 31, 2026
@gcanlin gcanlin added the nightly-test label to trigger buildkite nightly test CI label Mar 31, 2026
@yenuo26 yenuo26 requested a review from gcanlin March 31, 2026 12:33
@gcanlin gcanlin removed the nightly-test label to trigger buildkite nightly test CI label Mar 31, 2026
@gcanlin gcanlin enabled auto-merge (squash) March 31, 2026 13:31
Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcanlin gcanlin merged commit 642f169 into vllm-project:main Mar 31, 2026
7 of 8 checks passed
vraiti pushed a commit to vraiti/vllm-omni that referenced this pull request Apr 9, 2026
…ions and optimize CUDA memory management (vllm-project#2354)

Signed-off-by: wangyu <410167048@qq.com>
@yenuo26 yenuo26 deleted the whisper branch April 21, 2026 01:38
lengrongfu pushed a commit to lengrongfu/vllm-omni that referenced this pull request May 1, 2026
…ions and optimize CUDA memory management (vllm-project#2354)

Signed-off-by: wangyu <410167048@qq.com>
clodaghwalsh17 pushed a commit to clodaghwalsh17/nm-vllm-omni-ent that referenced this pull request May 12, 2026
…ions and optimize CUDA memory management (vllm-project#2354)

Signed-off-by: wangyu <410167048@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants